From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5FDB389E02; Tue, 10 Mar 2026 11:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773141925; cv=none; b=GeyF06+EW0ZTTsj/zNt3+NEoO2WbQeHluX/eAxFOvera/NrXywCACi1CPHpDlxIhZO7YwiiSHS6GHqAmOe4UCukzYk7q4D7LYe2BO6NrNhDuIYhhu4bVchOVL6NezfJugtGJwQrj56Vpdoh/+r+XvqKMBsaX3+Hr8dMJ2CtQb64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773141925; c=relaxed/simple; bh=75uQKiEqPk0+2/ZkqrB2GSYPQ3tvBpPthpZBU+7h0pM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jML7cCiyOlYnDSSWSELLL/rFDgYZeUdD3I+ga/nbc8sXXCXogk3tUabeavhwCusVF4EgSQznP0DtwUWvYXHC3D7n9kL5WBEAmijMXQPd03D5JcWUiN2QksiTrhUUJCtWxnHndJhR8gseUkwRCO2jcD78Fk4D1AMXDSb5uBOSlyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C5vHH7pT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C5vHH7pT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDB80C19423; Tue, 10 Mar 2026 11:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773141925; bh=75uQKiEqPk0+2/ZkqrB2GSYPQ3tvBpPthpZBU+7h0pM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C5vHH7pTYgFAc6j/t5kHPsXfObvtaTv8EcqWoKoSBcma1mgYqjEWlhOmB3God9N9A JEfxzXUA1g+X1glx+oyB/Mmt9RjkOMgSrpsrnNWPmBSN2J463g98HL7pR8X215XHdG IxApbiyzZEI+gpvjRf0Na49PD4SDyUDThEc5orXXu79j6ashSdWfOqVnCqCpyTHYc4 s8PTqppm67lEfU5Hl0flncaq83gjPBnpWH3k+Cw5/uVE23gS7oO8X3Cp+MQpu99vfZ 0vWp4GQhagVnG/Un5ahjRBibJBsHvMK/j9UdyEW/CiLavTP7no9yaL38EzmhU4BOLf J2fwKAOdyvm2Q== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Bart Van Assche , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Yang Wang , Hawking Zhang , amd-gfx@lists.freedesktop.org, Sasha Levin Subject: [PATCH 6.18 049/314] drm/amdgpu: Unlock a mutex before destroying it Date: Tue, 10 Mar 2026 07:15:08 -0400 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Bart Van Assche [ Upstream commit 5e0bcc7b88bcd081aaae6f481b10d9ab294fcb69 ] Mutexes must be unlocked before these are destroyed. This has been detected by the Clang thread-safety analyzer. Cc: Alex Deucher Cc: Christian König Cc: Yang Wang Cc: Hawking Zhang Cc: amd-gfx@lists.freedesktop.org Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework") Reviewed-by: Yang Wang Acked-by: Christian König Signed-off-by: Bart Van Assche Signed-off-by: Alex Deucher (cherry picked from commit 270258ba320beb99648dceffb67e86ac76786e55) Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index 9b31804491500..3f9b094e93a29 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr) aca_bank_error_remove(aerr, bank_error); out_unlock: + mutex_unlock(&aerr->lock); mutex_destroy(&aerr->lock); } -- 2.51.0