Archive-only list for patches
 help / color / mirror / Atom feed
From: heyuqiang <heyuqiang1@huawei.com>
To: <gregkh@linuxfoundation.org>, <anshuman.khandual@arm.com>,
	<catalin.marinas@arm.com>, <james.morse@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>,
	<stable@vger.kernel.org>, <will@kernel.org>,
	<yuzenghui@huawei.com>
Cc: <nixiaoming@huawei.com>, <lijiahuan5@huawei.com>
Subject: Re: [PATCH 5.10 88/91] arm64/kexec: Test page size support with new TGRAN range values
Date: Wed, 15 Feb 2023 18:58:13 +0800	[thread overview]
Message-ID: <e1daca8f-46d5-d5b0-8152-23b172d5e63a@huawei.com> (raw)

There is an error

tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git 
master
head: c911f03f8d444e623724fddd82b07a7e1af42338
commit: d5924531dd8ad012ad13eb4d6a5e120c3dadfc05 arm64/kexec: Test page 
size support with new TGRAN range values
# 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5924531dd8ad012ad13eb4d6a5e120c3dadfc05

When I compile the ko file, I add [-Werror=type-limits] compilation 
options, an error is reported during compilation.

The log is as follows:

./arch/arm64/include/asm/cpufeature.h: In function 
‘system_supports_4kb_granule’:
./arch/arm64/include/asm/cpufeature.h:653:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN) &&
^~
./arch/arm64/include/asm/cpufeature.h: In function 
‘system_supports_64kb_granule’:
./arch/arm64/include/asm/cpufeature.h:666:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN) &&
^~

"val" variable type is "u32"
"#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0"
"#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0"
comparison of val >= 0 is always true.

If you fix the issue, kindly add following tag where applicable
Reported-by: heyuqiang <heyuqiang1@huawei.com>

Thanks


             reply	other threads:[~2023-02-15 10:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 10:58 heyuqiang [this message]
2023-02-15 11:41 ` [PATCH 5.10 88/91] arm64/kexec: Test page size support with new TGRAN range values Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2022-11-02  2:32 [PATCH 5.10 00/91] 5.10.153-rc1 review Greg Kroah-Hartman
2022-11-02  2:34 ` [PATCH 5.10 88/91] arm64/kexec: Test page size support with new TGRAN range values Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1daca8f-46d5-d5b0-8152-23b172d5e63a@huawei.com \
    --to=heyuqiang1@huawei.com \
    --cc=20221102022057.553634951@linuxfoundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.morse@arm.com \
    --cc=lijiahuan5@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nixiaoming@huawei.com \
    --cc=patches@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox