From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE5219D062 for ; Mon, 14 Oct 2024 12:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910117; cv=none; b=VAIItDpHuaXvSL5oAf9cia+OviKvi0gtPKjAfrIkRB3zI/YlimcshwisJLf5ABd3LnbWvXo5uZQn3POe67fB7c0aco89GiuNvEceBhAgOwo/06t+B+l+3IXRMzIeU+kE1R2Kf0A5k3t1WB3hOlFu7oiZl+lemJ2A9g37YYoonCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728910117; c=relaxed/simple; bh=MhLSQQZS4zqkgAHrN17LB8PubEgDApvdabVlLEP6zsc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=ICtouDymsiOUsfZwK8Z8rY3TI6QyYNT044F82GywhQzaAGgPXhktj463cJbqQU+TttnJZj3Bk3g5s/Ch8PymHr9qO+IWcKXkl6z2dCnf/8zZ0h0hrV1EdHTwBZfrb9OR+BkoK1SYvk9awX5N7nfwQLxhAaChsxcCwXYxgvLUzU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fXdA3DBh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fXdA3DBh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728910114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jz+O7ng0GFJAWN74rY5sF0aBksxpe7VRWGO4WN6Z/Hk=; b=fXdA3DBhiYOBT/AmQBIuyTlGSV9atxLbSuNJ76mxfnC0TbxAjiMzSyW1j7p8e5pJLjDLsE FPu5r99C4g50hMLKWNfVuakzgzhfvlPj2ujGmlpY6do1d6d+fWNJCMHgfl+PJhCHTao5MO /BXQotfTg5QPO2qKET9dajsTBUMmeqs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-iBchn3atOIK8aiO-1Z4__A-1; Mon, 14 Oct 2024 08:48:33 -0400 X-MC-Unique: iBchn3atOIK8aiO-1Z4__A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d589138a9so1351108f8f.1 for ; Mon, 14 Oct 2024 05:48:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728910112; x=1729514912; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jz+O7ng0GFJAWN74rY5sF0aBksxpe7VRWGO4WN6Z/Hk=; b=nMnEKw2d4JyjEAPWHu+GvhN3+dNgbvmyxEfz2bPfqi+cBZPuxqA5tjX0LLicjQPY4P mhWL98Xkq9dfvVP1rrtwzHnyuH6z81XFxQB+bv9w2Od7KlfnZfDIE9vYXfTpqkg+cIjL Ufj7glugEipVi3Eyl08A/ajgadgXFbAPA4TOdpdO3cA1eY3WCZt3RxGEl18fJDlUhzDm nZ7gsgwaie32kw0V3c7iJBNK2tUWR1a5f5xQXH6s1dsndhRs6D+rD+PFlUzcv98L9Qe2 AZqZM54IyrRztZYOXK9Nov+dNjmhsTHwVfltg88OzqPcgeczuS+gb6gy7F4rpKaVvkzc 5vJQ== X-Forwarded-Encrypted: i=1; AJvYcCVFWbLlLKQZQ7qt/ph3YD9UR3BYw6X5RbjTYjK49q4uLD4nwy37LDAbdW7oHXHy4mUzeWSpqjqW@lists.linux.dev X-Gm-Message-State: AOJu0YwM5ToDD68PWmkExIf6WR5Bwb6RRdz2tgBkRx78e3QG/E80PLbu R6hqFuHisS7cS7ZyXQf3Zfs+MQDrKpdjx9q2l+FuMGJGzi3XGbJ4F4L+7pWDiLA6x9Fmehdfn86 Br8NjKFma4XbvJqHklt9hTrmXyUkhzNP7v00q2Mr659AbP8Yhf+Z2t1U= X-Received: by 2002:a05:600c:3b13:b0:42c:baf9:bee7 with SMTP id 5b1f17b1804b1-4311decab14mr92387645e9.12.1728910111952; Mon, 14 Oct 2024 05:48:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNKMVr8mP2u3/Zc4ug5AuewCTZ9DL/dFTdj/lE65CnsD7NnambyLw3qSxBo5sKDk5QAfMgnA== X-Received: by 2002:a05:600c:3b13:b0:42c:baf9:bee7 with SMTP id 5b1f17b1804b1-4311decab14mr92387475e9.12.1728910111614; Mon, 14 Oct 2024 05:48:31 -0700 (PDT) Received: from ?IPV6:2a01:e0a:c:37e0:ced3:55bd:f454:e722? ([2a01:e0a:c:37e0:ced3:55bd:f454:e722]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b7ee4aasm11245969f8f.95.2024.10.14.05.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 05:48:31 -0700 (PDT) Message-ID: Date: Mon, 14 Oct 2024 14:48:29 +0200 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE From: Jocelyn Falempe To: Miguel Ojeda , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev References: <20241003230734.653717-1-ojeda@kernel.org> <609cf7e5-0fd6-4636-b5b1-b63fe319db28@redhat.com> In-Reply-To: <609cf7e5-0fd6-4636-b5b1-b63fe319db28@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/10/2024 09:14, Jocelyn Falempe wrote: > On 04/10/2024 01:07, Miguel Ojeda wrote: >> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used: >> >>      ld.lld: error: undefined symbol: zlib_deflate_workspacesize >>      >>> referenced by drm_panic.c >>      >>>               drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) >> in archive vmlinux.a >> >> Thus select `CONFIG_ZLIB_DEFLATE`. > > Hi, good catch, yes it should select the zlib deflate. > > Reviewed-by: Jocelyn Falempe I've just pushed it to drm-misc-next. Thanks for your contribution. -- Jocelyn > > Best regards, >