From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CEDF1FC1 for ; Tue, 15 Nov 2022 03:34:27 +0000 (UTC) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NBBbq4bBNzHvrm; Tue, 15 Nov 2022 11:33:43 +0800 (CST) Received: from [10.174.178.66] (10.174.178.66) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 15 Nov 2022 11:34:12 +0800 Message-ID: Date: Tue, 15 Nov 2022 11:34:12 +0800 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH 5.15 000/131] 5.15.79-rc1 review To: Naresh Kamboju , Greg Kroah-Hartman CC: , , , , , , , , , , , , , , , Leon Romanovsky , Paolo Abeni , Sasha Levin References: <20221114124448.729235104@linuxfoundation.org> From: shaozhengchao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.66] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected On 2022/11/15 10:56, Naresh Kamboju wrote: > On Mon, 14 Nov 2022 at 18:24, Greg Kroah-Hartman > wrote: >> >> This is the start of the stable review cycle for the 5.15.79 release. >> There are 131 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these being applied, please >> let me know. >> >> Responses should be made by Wed, 16 Nov 2022 12:44:21 +0000. >> Anything received after that time might be too late. >> >> The whole patch series can be found in one patch at: >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.79-rc1.gz >> or in the git tree and branch at: >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y >> and the diffstat can be found below. >> >> thanks, >> >> greg k-h > > As others reported, > arm: allmodconfig failed [1] due to following warnings / errors. > > drivers/net/ethernet/mediatek/mtk_star_emac.c: In function 'mtk_star_enable': > drivers/net/ethernet/mediatek/mtk_star_emac.c:980:22: error: 'struct > mtk_star_priv' has no member named 'rx_napi'; did you mean 'napi'? > 980 | napi_disable(&priv->rx_napi); > | ^~~~~~~ > | napi > drivers/net/ethernet/mediatek/mtk_star_emac.c:981:22: error: 'struct > mtk_star_priv' has no member named 'tx_napi'; did you mean 'napi'? > 981 | napi_disable(&priv->tx_napi); > | ^~~~~~~ > | napi > > > --- > net: ethernet: mtk-star-emac: disable napi when connect and start PHY > failed in mtk_star_enable() > [ Upstream commit b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8 ] > > > [1] https://builds.tuxbuild.com/2HXmwUDUvmWI1Uc7zsdXNcsTqW1/ > > -- > Linaro LKFT > https://lkft.linaro.org Yes ,For stable-5.10, commit 0a8bd81fd6aaace14979152e0540da8ff158a00a ("net: ethernet: mtk-star-emac: separate tx/rx handling with two NAPIs") is not merged. So, please use napi_disable(&priv->napi) instead of napi_disable(&priv->rx_napi) and napi_disable(&priv->tx_napi).