From: Finn Thain <fthain@linux-m68k.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Colin Ian King <colin.i.king@gmail.com>,
linux-scsi@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH] scsi: dc395x: Remove leftover if statement in reselect()
Date: Thu, 1 May 2025 10:20:05 +1000 (AEST) [thread overview]
Message-ID: <f0842307-a0e9-6e50-e6be-b25e38ca7120@linux-m68k.org> (raw)
In-Reply-To: <06495223-342d-4759-995f-f62234fb1020@suse.com>
On Wed, 30 Apr 2025, Oliver Neukum wrote:
> On 30.04.25 11:43, Finn Thain wrote:
>
> >> yes, I was unsure about terminology used for code that is by default not
> >> compiled, but would not compile if the attempt is made to compile it.
> >>
> >
> > Yes, I realize that you were referring to the intention as "cleanup" and
> > not the actual patch that got merged.
> >
> > I'm afraid my message was poorly expressed. I don't have a problem with
> > your fix. I was only interested in the general case.
>
> Well, in general I think such code is problematic. In general I think we
> should use dynamic debugging statements. The issue seems to be of
> terminology. However, we can hope that this will go away and become
> moot.
>
I think you're saying that the general problem is the style of the
debugging code that everyone disables. I'm afraid I don't see it that way.
The general problem here is a bad cleanup masquerading as a fix that got
merged because of a missed opportunity for automated vetting.
next prev parent reply other threads:[~2025-05-01 0:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 0:46 [PATCH] scsi: dc395x: Remove leftover if statement in reselect() Nathan Chancellor
2025-04-30 1:36 ` Finn Thain
2025-04-30 7:39 ` Oliver Neukum
2025-04-30 9:43 ` Finn Thain
2025-04-30 12:11 ` Oliver Neukum
2025-05-01 0:20 ` Finn Thain [this message]
2025-05-06 2:01 ` Martin K. Petersen
2025-05-13 2:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0842307-a0e9-6e50-e6be-b25e38ca7120@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=aliakc@web.de \
--cc=colin.i.king@gmail.com \
--cc=lenehan@twibble.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=oneukum@suse.com \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).