From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
David Ahern <dsahern@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Itay Avraham <itayavr@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>, <linux-doc@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
"Aron Silverton" <aron.silverton@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>, <linux-cxl@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH 0/8] Introduce fwctl subystem
Date: Fri, 7 Jun 2024 12:47:41 +0200 [thread overview]
Message-ID: <f1ad4141-c72c-47ee-9cf3-42ff550661d1@intel.com> (raw)
In-Reply-To: <20240607002536.GI19897@nvidia.com>
On 6/7/24 02:25, Jason Gunthorpe wrote:
> On Thu, Jun 06, 2024 at 10:24:46AM -0700, Dan Williams wrote:
>> Jason Gunthorpe wrote:
>> [..]
>>>> I am warming to your assertion that there is a wide array of
>>>> vendor-specific configuration and debug that are not an efficient use of
>>>> upstream's time to wrap in a shared Linux ABI. I want to explore fwctl
>>>> for CXL for that use case, I personally don't want to marshal a Linux
>>>> command to each vendor's slightly different backend CXL toggles.
>>>
>>> Personally I think this idea to marshal/unmarshal everything in the
>>> kernel is often misguided. If it is truely obvious and actually shared
>>> multi-vendor capability then by all means go and do it.
>>>
>>> But if you are spending weeks/months fighting about uAPI because all
>>> the vendors are so different, it isn't obvious what is "generic" then
>>> you've probably already lost. The very worst outcome is a per-device
>>> uAPI masquerading as an obfuscated "generic" uAPI that wasted ages of
>>> peoples time to argue out.
>>
>> Certainly once you have gotten to the "months of arguing" point it begs the
>> question "was there really any generic benefit to reap in the first
>> place?"
>
> Indeed, but I've seen, and participated, in these things many times :)
>
>> That said, *some* grappling, especially when muliple vendors hit the
>> list with the similar feature at the same time, has yielded
>> collaboration in the past.
>
> Absolutely! But we have also frequently done that retroactively, like
> see three examples and then consolidate the common APIs. The challenge
> is uAPI. Since we can't change uAPI people like to rush to make it
> future proof without examples. Broadly I lean towards waiting until we
> have several examples to build a standard uAPI and let the examples
> evolve on their own.
>
> If there is value in the commonality then people will change over.
what has changed over decades is that now Linux has much more users than
implementations of given tool
I would love to see a move of the uAPI barrier closer to the user,
we will be free to refactor kernel APIs, given "the system tool" will be
updated at the same time.
Obviously for a new uAPI that would (re)move the promise on the very
beginning.
next prev parent reply other threads:[~2024-06-07 10:47 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 15:53 [PATCH 0/8] Introduce fwctl subystem Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 1/8] fwctl: Add basic structure for a class subsystem with a cdev Jason Gunthorpe
2024-06-04 9:32 ` Leon Romanovsky
2024-06-04 15:50 ` Jason Gunthorpe
2024-06-04 17:05 ` Jonathan Cameron
2024-06-04 18:52 ` Jason Gunthorpe
2024-06-05 11:08 ` Jonathan Cameron
2024-06-04 16:42 ` Randy Dunlap
2024-06-04 16:44 ` Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 2/8] fwctl: Basic ioctl dispatch for the character device Jason Gunthorpe
2024-06-04 12:16 ` Zhu Yanjun
2024-06-04 12:22 ` Leon Romanovsky
2024-06-04 16:50 ` Jonathan Cameron
2024-06-04 16:58 ` Jason Gunthorpe
2024-06-05 11:07 ` Jonathan Cameron
2024-06-05 18:27 ` Jason Gunthorpe
2024-06-06 13:34 ` Jonathan Cameron
2024-06-06 15:37 ` Randy Dunlap
2024-06-05 15:42 ` Przemek Kitszel
2024-06-05 15:49 ` Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 3/8] fwctl: FWCTL_INFO to return basic information about the device Jason Gunthorpe
2024-06-13 23:32 ` Dave Jiang
2024-06-13 23:40 ` Jason Gunthorpe
2024-06-14 16:37 ` Dave Jiang
2024-06-03 15:53 ` [PATCH 4/8] taint: Add TAINT_FWCTL Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 5/8] fwctl: FWCTL_RPC to execute a Remote Procedure Call to device firmware Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 6/8] fwctl: Add documentation Jason Gunthorpe
2024-06-05 2:31 ` Randy Dunlap
2024-06-05 16:03 ` Jason Gunthorpe
2024-06-05 20:14 ` Randy Dunlap
2024-06-03 15:53 ` [PATCH 7/8] fwctl/mlx5: Support for communicating with mlx5 fw Jason Gunthorpe
2024-06-03 15:53 ` [PATCH 8/8] mlx5: Create an auxiliary device for fwctl_mlx5 Jason Gunthorpe
2024-06-03 18:42 ` [PATCH 0/8] Introduce fwctl subystem Jakub Kicinski
2024-06-04 3:01 ` David Ahern
2024-06-04 14:04 ` Jakub Kicinski
2024-06-04 21:28 ` Saeed Mahameed
2024-06-04 22:32 ` Jakub Kicinski
2024-06-05 14:50 ` Jason Gunthorpe
2024-06-05 15:41 ` Jakub Kicinski
2024-06-04 23:56 ` Dan Williams
2024-06-05 3:05 ` Jakub Kicinski
2024-06-05 11:19 ` Jonathan Cameron
2024-06-05 13:59 ` Jason Gunthorpe
2024-06-06 2:35 ` David Ahern
2024-06-06 14:18 ` Jakub Kicinski
2024-06-06 14:48 ` Jason Gunthorpe
2024-06-06 15:05 ` Jakub Kicinski
2024-06-06 17:47 ` David Ahern
2024-06-07 6:48 ` Jiri Pirko
2024-06-07 14:50 ` David Ahern
2024-06-07 15:14 ` Jason Gunthorpe
2024-06-07 15:50 ` Jiri Pirko
2024-06-07 17:24 ` Jason Gunthorpe
2024-06-07 7:34 ` Jiri Pirko
2024-06-07 12:49 ` Andrew Lunn
2024-06-07 13:34 ` Jiri Pirko
2024-06-08 1:43 ` Jakub Kicinski
2024-06-06 4:56 ` Dan Williams
2024-06-06 8:50 ` Leon Romanovsky
2024-06-06 22:11 ` Dan Williams
2024-06-07 0:02 ` Jason Gunthorpe
2024-06-07 13:12 ` Leon Romanovsky
2024-06-06 14:41 ` Jason Gunthorpe
2024-06-06 14:58 ` Jakub Kicinski
2024-06-06 17:24 ` Dan Williams
2024-06-07 0:25 ` Jason Gunthorpe
2024-06-07 10:47 ` Przemek Kitszel [this message]
2024-06-11 15:36 ` Daniel Vetter
2024-06-11 16:17 ` Jason Gunthorpe
2024-06-11 16:54 ` Daniel Vetter
2024-06-06 1:58 ` David Ahern
2024-06-05 3:11 ` Jakub Kicinski
2024-06-05 12:06 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ad4141-c72c-47ee-9cf3-42ff550661d1@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=aron.silverton@oracle.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dsahern@kernel.org \
--cc=hch@infradead.org \
--cc=itayavr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lbloch@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patches@lists.linux.dev \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox