Archive-only list for patches
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Dongsheng Yang <dongsheng.yang@linux.dev>,
	Zheng Gu <cengku@gmail.com>,
	 dm-devel@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH] dm-pcache: Fix 64-bit division for 32-bit platforms in get_kset_id()
Date: Mon, 25 Aug 2025 15:28:40 +0200 (CEST)	[thread overview]
Message-ID: <f9793847-deb5-67ba-c875-927fadbc2cf0@redhat.com> (raw)
In-Reply-To: <20250821-dm-pcache-fix-32-bit-div-err-v1-1-cab5448f44e6@kernel.org>



On Thu, 21 Aug 2025, Nathan Chancellor wrote:

> When building for a 32-bit platform (such as ARCH=i386 allmodconfig),
> there is a modpost error:
> 
>   ERROR: modpost: "__umoddi3" [drivers/md/dm-pcache/dm-pcache.ko] undefined!
> 
> Hacking up the driver Makefile to allow building into the kernel shows
> that the division comes from get_kset_id(), which is inlined into
> cache_key_append() in cache_key.c.
> 
> Use the helper div_u64_rem() to avoid emitting a libcall on 32-bit targets.
> 
> Fixes: fd5cc4922bef ("dm-pcache: add persistent cache target in device-mapper")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks.

I folded it into the existing dm-pcache commit.

Mikulas


      parent reply	other threads:[~2025-08-25 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 20:09 [PATCH] dm-pcache: Fix 64-bit division for 32-bit platforms in get_kset_id() Nathan Chancellor
2025-08-22  6:53 ` Dongsheng Yang
2025-08-23  5:27   ` Nathan Chancellor
2025-08-25 13:28 ` Mikulas Patocka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9793847-deb5-67ba-c875-927fadbc2cf0@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=cengku@gmail.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=dongsheng.yang@linux.dev \
    --cc=nathan@kernel.org \
    --cc=patches@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox