From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914BDA21 for ; Thu, 6 Apr 2023 08:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1680770914; x=1712306914; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=eCCEIPDsX9p6xMK5oOcfZQj/UVGS7/pUHr5w0Qxmn+A=; b=KSysOrP+GCmNfSmUqQZmPrDgCnlKbk+m99FR8MzfA2RnbIi7BYKJynM0 IGsB4WPKA8UZfsra6c41ZogpinYA1fFroyol4t+G85Eym8FMk6SXajeAR HUacdKhe4/z38BBnVZR8kDcg1pj9lzQZsdAfiCXZ8OSNyaPtClR+BvEZa w=; X-IronPort-AV: E=Sophos;i="5.98,323,1673913600"; d="scan'208";a="326711923" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-pdx-2a-m6i4x-83883bdb.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 08:48:28 +0000 Received: from EX19MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-m6i4x-83883bdb.us-west-2.amazon.com (Postfix) with ESMTPS id 6539060148; Thu, 6 Apr 2023 08:48:26 +0000 (UTC) Received: from EX19MTAUWC001.ant.amazon.com (10.250.64.145) by EX19MTAUWB001.ant.amazon.com (10.250.64.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 6 Apr 2023 08:48:26 +0000 Received: from dev-dsk-ptyadav-1c-37607b33.eu-west-1.amazon.com (10.15.11.255) by mail-relay.amazon.com (10.250.64.145) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Thu, 6 Apr 2023 08:48:25 +0000 Received: by dev-dsk-ptyadav-1c-37607b33.eu-west-1.amazon.com (Postfix, from userid 23027615) id 72E1622BC6; Thu, 6 Apr 2023 10:48:24 +0200 (CEST) From: Pratyush Yadav To: Greg Kroah-Hartman CC: Steve French , Amir Goldstein , Aurelien Aptel , , , Sasha Levin Subject: Re: [PATCH 5.4] smb3: fix problem with null cifs super block with previous patch References: <20230405135709.100174-1-ptyadav@amazon.de> <2023040523-delusion-corrode-f466@gregkh> <2023040514-ravishing-problem-9302@gregkh> Date: Thu, 6 Apr 2023 10:48:24 +0200 In-Reply-To: <2023040514-ravishing-problem-9302@gregkh> (Greg Kroah-Hartman's message of "Wed, 5 Apr 2023 19:04:35 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Apr 05 2023, Greg Kroah-Hartman wrote: > On Wed, Apr 05, 2023 at 04:34:00PM +0200, Pratyush Yadav wrote: >> On Wed, Apr 05 2023, Greg Kroah-Hartman wrote: >> >> > On Wed, Apr 05, 2023 at 03:57:09PM +0200, Pratyush Yadav wrote: >> >> From: Steve French >> >> >> >> [ Upstream commit 87f93d82e0952da18af4d978e7d887b4c5326c0b ] >> >> >> >> Add check for null cifs_sb to create_options helper >> >> >> >> Signed-off-by: Steve French >> >> Reviewed-by: Amir Goldstein >> >> Reviewed-by: Aurelien Aptel >> >> Signed-off-by: Pratyush Yadav >> >> --- >> >> >> >> Only compile-tested. This was discovered by our static code analysis >> >> tool. I do not use CIFS and do not know how to actually reproduce the >> >> NULL dereference. >> >> >> >> Follow up from [0]. Original patch is at [1]. >> >> >> >> Mandatory text due to licensing terms: >> >> >> >> This bug was discovered and resolved using Coverity Static Analysis >> >> Security Testing (SAST) by Synopsys, Inc. >> > >> > What? That's funny. And nothing I'm going to be adding to the >> > changelog text, sorry, as that's not what is upstream. >> >> That is fine by me. I placed this text below the 3 dashed lines so it >> does _not_ end up in the commit message, but still discloses this >> information. >> >> > Please go poke your lawyers, that's not ok. >> >> Yes, perhaps I should. But let's go forward with this patch since it >> keeps the original commit message? > > It's already been queued up, you should have gotten an email saying > that, right? Yes, I did, thanks! There was a bit of a race in me sending that email and receiving the notification. -- Regards, Pratyush Yadav Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879