From: Jingoo Han <jg1.han@samsung.com>
To: 'Kishon Vijay Abraham I' <kishon@ti.com>
Cc: 'Bjorn Helgaas' <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
'Kukjin Kim' <kgene.kim@samsung.com>,
'Pratyush Anand' <pratyush.anand@st.com>,
'Mohit KUMAR' <Mohit.KUMAR@st.com>,
'Arnd Bergmann' <arnd@arndb.de>, 'Sean Cross' <xobs@kosagi.com>,
'SRIKANTH TUMKUR SHIVANAND' <ts.srikanth@samsung.com>,
linux-kernel@vger.kernel.org,
Seungwon Jeon <tgih.jun@samsung.com>,
'Yulgon Kim' <yulgon.kim@samsung.com>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH V2] pci: exynos: split into two parts such as Synopsys part and Exynos part
Date: Thu, 11 Jul 2013 16:05:50 +0900 [thread overview]
Message-ID: <000001ce7e05$13ab4210$3b01c630$@samsung.com> (raw)
In-Reply-To: <51DE5359.90905@ti.com>
On Thursday, July 11, 2013 3:40 PM, Kishon Vijay Abraham I wrote:
> On Thursday 11 July 2013 11:19 AM, Jingoo Han wrote:
> >
> > drivers/pci/host/Makefile | 1 +
> > drivers/pci/host/pcie-designware.c | 963 +++++++++---------------------------
> > drivers/pci/host/pcie-designware.h | 71 +++
> > drivers/pci/host/pcie-exynos.c | 523 ++++++++++++++++++++
> > 4 files changed, 822 insertions(+), 736 deletions(-)
> > create mode 100644 drivers/pci/host/pcie-designware.h
> > create mode 100644 drivers/pci/host/pcie-exynos.c
> >
> > diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
> > index 086d850..7e59864 100644
> > --- a/drivers/pci/host/Makefile
> > +++ b/drivers/pci/host/Makefile
> > @@ -1,2 +1,3 @@
> > obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o
> > obj-$(CONFIG_PCIE_DW) += pcie-designware.o
> > +obj-$(CONFIG_PCI_EXYNOS) += pcie-exynos.o
> > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
[...]
>
> How about making this a separate driver in itself that does all the
> configurations for designware core? By this I mean we can have a separate dt
> node (child node of soc specific wrapper), that will have all the configuration
> space/IO space and memory space. pci_common_init/dw_pcie_host_init should be
> done in this driver.
> We just need to think about a way of passing the ops (since that looks like
> very much needed because of the sideband bits you have to enable before
> reading/writing).
>
CC'ed Seungwon Jeon(DW-MMC Maintainer), Yulgon Kim (DW-USB Developer)
Um, maybe you mean dwc3 usb driver (./drivers/usb/dwc3/)'?
But, I referenced dw mmc driver (./drivers/mmc/host/dw_mmc*.c).
Now, Exynos PCIe driver, Spear PCIe driver[1], and i.MX PCIe driver[2]
are submitted to PCIe mailing-list, these are using designware PCIe core.
There are many differences between Exynos PCIe and Spear PCIe.
Also, for Exynos PCIe, platform specific part will be changed more.
Thus, the dw mmc driver model looked more suitable.
[1] http://permalink.gmane.org/gmane.linux.kernel.pci/18400
[2] http://www.spinics.net/lists/linux-pci/msg23489.html
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-07-11 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 5:49 [PATCH V2] pci: exynos: split into two parts such as Synopsys part and Exynos part Jingoo Han
2013-07-11 6:40 ` Kishon Vijay Abraham I
2013-07-11 7:05 ` Jingoo Han [this message]
2013-07-11 8:35 ` Kishon Vijay Abraham I
2013-07-11 8:54 ` Kishon Vijay Abraham I
2013-07-12 0:00 ` Jingoo Han
2013-07-12 5:23 ` Kishon Vijay Abraham I
2013-07-11 15:41 ` Thierry Reding
2013-07-11 23:28 ` Jingoo Han
2013-07-12 17:15 ` Thierry Reding
2013-07-15 8:26 ` Jingoo Han
2013-07-12 10:01 ` Kishon Vijay Abraham I
2013-07-12 17:31 ` Thierry Reding
2013-07-15 8:25 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ce7e05$13ab4210$3b01c630$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Mohit.KUMAR@st.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=tgih.jun@samsung.com \
--cc=ts.srikanth@samsung.com \
--cc=xobs@kosagi.com \
--cc=yulgon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).