From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: "'Logan Gunthorpe'" <logang@deltatee.com>,
"'Jon Mason'" <jdmason@kudzu.us>
Cc: <linux-ntb@googlegroups.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"'Dave Jiang'" <dave.jiang@intel.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Kurt Schwemmer'" <kurt.schwemmer@microsemi.com>,
"'Stephen Bates'" <sbates@raithlin.com>,
"'Serge Semin'" <fancer.lancer@gmail.com>
Subject: RE: [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers
Date: Wed, 2 Aug 2017 09:06:42 -0400 [thread overview]
Message-ID: <000001d30b90$31697f70$943c7e50$@dell.com> (raw)
In-Reply-To: <dda576ad-d3ca-814b-f0cf-478cbb61adf2@deltatee.com>
From: Logan Gunthorpe
> On 01/08/17 01:10 PM, Jon Mason wrote:
> > It would probaly be better if I remarked about the SPADs in the actual
> > patch about the SPADS :)
> >
> > The whole point of using the SPADs in the NTB driver was to workaround
> > the problems establishing a connection between the two sides of the
> > NTB and where everything lives. So, using a MW to get around the
> > SPADs is sort of backwards (and slightly funny). I realize you are
> > trying to use the existing transport with minimal changes to enable
> > your hardware, and thus this makes logical sense to you. However, if
> > the SPADs are not really needed, then we should either remove them
> > from the transport (or use them for something else).
> >
> > Per my comment in the other patch, I'm amenable to take this series
> > as-is, assuming you are willing to address this design issue in the
> > near future. Thoughts?
>
> Yes, I agree. I'd be willing to help but it seems the clients are
> written the way they are for the other drivers, so it's their needs
> (which I'm not fully aware of) that have to be considered.
The proposed change, removing use of spads from transport, would not affect ntrdma.
> I've also made all the other changes you sent as well as the file rename
> Dave requested. Once I see the bug fix patch you were going to pull hit
> ntb-next I'll rebase, test and resubmit.
>
> Thanks,
>
> Logan
next prev parent reply other threads:[~2017-08-02 13:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 20:57 [PATCH v3 00/16] Switchtec NTB Support Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe
2017-07-31 20:15 ` Bjorn Helgaas
2017-07-31 20:51 ` Logan Gunthorpe
2017-07-31 22:50 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 02/16] switchtec: export class symbol for use in upper layer driver Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 03/16] switchtec: add NTB hardware register definitions Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 04/16] switchtec: add link event notifier callback Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws Logan Gunthorpe
2017-08-01 18:07 ` Jon Mason
2017-08-01 18:09 ` Logan Gunthorpe
2017-08-01 18:16 ` Jon Mason
2017-08-01 18:19 ` Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up Logan Gunthorpe
2017-07-31 20:16 ` Bjorn Helgaas
2017-08-01 18:14 ` Jon Mason
2017-08-01 18:17 ` Logan Gunthorpe
2017-08-01 18:28 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 07/16] ntb: add check and comment for link up to mw_count() and mw_get_align() Logan Gunthorpe
2017-08-01 18:11 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 08/16] switchtec_ntb: introduce initial NTB driver Logan Gunthorpe
2017-07-31 23:08 ` Dave Jiang
2017-07-25 20:57 ` [PATCH v3 09/16] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe
2017-07-31 20:25 ` Bjorn Helgaas
2017-08-01 18:55 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 10/16] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe
2017-07-31 20:26 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 11/16] switchtec_ntb: add skeleton NTB driver Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 12/16] switchtec_ntb: add link management Logan Gunthorpe
2017-07-31 20:27 ` Bjorn Helgaas
2017-07-25 20:57 ` [PATCH v3 13/16] switchtec_ntb: implement doorbell registers Logan Gunthorpe
2017-08-01 18:59 ` Jon Mason
2017-07-25 20:57 ` [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe
2017-08-01 19:10 ` Jon Mason
2017-08-01 22:26 ` Logan Gunthorpe
2017-08-02 13:06 ` Allen Hubbe [this message]
2017-08-02 16:32 ` Jon Mason
2017-08-02 17:02 ` Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 15/16] switchtec_ntb: add memory window support Logan Gunthorpe
2017-07-25 20:57 ` [PATCH v3 16/16] switchtec_ntb: update switchtec documentation with notes for NTB Logan Gunthorpe
2017-07-26 13:09 ` [PATCH v3 00/16] Switchtec NTB Support Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d30b90$31697f70$943c7e50$@dell.com' \
--to=allen.hubbe@dell.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).