From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com ([209.85.220.193]:44402 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbeCXODk (ORCPT ); Sat, 24 Mar 2018 10:03:40 -0400 Received: by mail-qk0-f193.google.com with SMTP id h14so15814664qkj.11 for ; Sat, 24 Mar 2018 07:03:39 -0700 (PDT) From: "Jingoo Han" To: "'Lorenzo Pieralisi'" , Cc: "'Rob Herring'" , "'Bjorn Helgaas'" , "'Linus Walleij'" , "'Xiaowei Song'" , "'Ray Jui'" , "'Scott Branden'" , "'Jon Mason'" , "'Joao Pinto'" , "'Thomas Petazzoni'" , "'Tanmay Inamdar'" , "'Shawn Lin'" , "'Ley Foon Tan'" , "'Fengguang Wu'" References: <20180321144254.7406-1-lorenzo.pieralisi@arm.com> <20180321144254.7406-10-lorenzo.pieralisi@arm.com> In-Reply-To: <20180321144254.7406-10-lorenzo.pieralisi@arm.com> Subject: Re: [PATCH v2 09/10] PCI: dwc: Move CONFIG_PCI depends to menu Date: Sat, 24 Mar 2018 10:03:37 -0400 Message-ID: <000001d3c378$e83efbd0$b8bcf370$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Wednesday, March 21, 2018 10:43 AM, Lorenzo Pieralisi wrote: > > From: Rob Herring > > There's no need for every config option to explicitly depend on > CONFIG_PCI, so move it out of individual option to the menu option. > > Signed-off-by: Rob Herring > Signed-off-by: Lorenzo Pieralisi Acked-by: Jingoo Han It looks good. Best regards, Jingoo Han > --- > drivers/pci/dwc/Kconfig | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig > index 6f2b653146bb..2902544f5834 100644 > --- a/drivers/pci/dwc/Kconfig > +++ b/drivers/pci/dwc/Kconfig > @@ -1,13 +1,13 @@ > # SPDX-License-Identifier: GPL-2.0 > > menu "DesignWare PCI Core Support" > + depends on PCI > > config PCIE_DW > bool > > config PCIE_DW_HOST > bool > - depends on PCI > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW > > @@ -22,7 +22,7 @@ config PCI_DRA7XX > config PCI_DRA7XX_HOST > bool "TI DRA7xx PCIe controller Host Mode" > depends on SOC_DRA7XX || COMPILE_TEST > - depends on PCI && PCI_MSI_IRQ_DOMAIN > + depends on PCI_MSI_IRQ_DOMAIN > depends on OF && HAS_IOMEM && TI_PIPE3 > select PCIE_DW_HOST > select PCI_DRA7XX > @@ -52,7 +52,6 @@ config PCI_DRA7XX_EP > > config PCIE_DW_PLAT > bool "Platform bus based DesignWare PCIe Controller" > - depends on PCI > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > ---help--- > @@ -65,7 +64,6 @@ config PCIE_DW_PLAT > > config PCI_EXYNOS > bool "Samsung Exynos PCIe controller" > - depends on PCI > depends on SOC_EXYNOS5440 || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -73,7 +71,6 @@ config PCI_EXYNOS > > config PCI_IMX6 > bool "Freescale i.MX6 PCIe controller" > - depends on PCI > depends on SOC_IMX6Q || (ARM && COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -81,7 +78,6 @@ config PCI_IMX6 > > config PCIE_SPEAR13XX > bool "STMicroelectronics SPEAr PCIe controller" > - depends on PCI > depends on ARCH_SPEAR13XX || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -91,7 +87,6 @@ config PCIE_SPEAR13XX > > config PCI_KEYSTONE > bool "TI Keystone PCIe controller" > - depends on PCI > depends on ARCH_KEYSTONE || (ARM && COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -104,7 +99,6 @@ config PCI_KEYSTONE > > config PCI_LAYERSCAPE > bool "Freescale Layerscape PCIe controller" > - depends on PCI > depends on OF && (ARM || ARCH_LAYERSCAPE || COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > select MFD_SYSCON > @@ -115,7 +109,6 @@ config PCI_LAYERSCAPE > config PCI_HISI > depends on OF && (ARM64 || COMPILE_TEST) > bool "HiSilicon Hip05 and Hip06 SoCs PCIe controllers" > - depends on PCI > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > select PCIE_DW_HOST > @@ -126,7 +119,6 @@ config PCI_HISI > > config PCIE_QCOM > bool "Qualcomm PCIe controller" > - depends on PCI > depends on OF && (ARCH_QCOM || COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -138,7 +130,6 @@ config PCIE_QCOM > > config PCIE_ARMADA_8K > bool "Marvell Armada-8K PCIe controller" > - depends on PCI > depends on ARCH_MVEBU || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > @@ -155,7 +146,7 @@ config PCIE_ARTPEC6 > config PCIE_ARTPEC6_HOST > bool "Axis ARTPEC-6 PCIe controller Host Mode" > depends on MACH_ARTPEC6 || COMPILE_TEST > - depends on PCI && PCI_MSI_IRQ_DOMAIN > + depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > select PCIE_DW_HOST > select PCIE_ARTPEC6 > @@ -177,7 +168,6 @@ config PCIE_KIRIN > depends on OF && (ARM64 || COMPILE_TEST) > bool "HiSilicon Kirin series SoCs PCIe controllers" > depends on PCI_MSI_IRQ_DOMAIN > - depends on PCI > select PCIEPORTBUS > select PCIE_DW_HOST > help > @@ -187,7 +177,6 @@ config PCIE_KIRIN > config PCIE_HISI_STB > bool "HiSilicon STB SoCs PCIe controllers" > depends on ARCH_HISI || COMPILE_TEST > - depends on PCI > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > select PCIE_DW_HOST > -- > 2.15.0