* [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440
@ 2014-04-01 2:54 Jingoo Han
2014-04-01 3:43 ` Pratyush Anand
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-04-01 2:54 UTC (permalink / raw)
To: 'Kukjin Kim'
Cc: linux-samsung-soc, linux-pci, 'Pratyush Anand',
'Jingoo Han'
Increase the size of PCIe configuration space to 8kB from 4kB,
because 4kB for cfg0 and 4kB for cfg1 are required respectively.
If 2kB for cfg0 and 2kB for cfg1 are set, it will make problems
when a PCIe card having multiple EPs below a bridge is used.
Suggested-by: Pratyush Anand <pratyush.anand@st.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
arch/arm/boot/dts/exynos5440.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index d600733..5d08be8 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -281,9 +281,9 @@
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
- ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00001000 /* configuration space */
- 0x81000000 0 0 0x40001000 0 0x00010000 /* downstream I/O */
- 0x82000000 0 0x40011000 0x40011000 0 0x1ffef000>; /* non-prefetchable memory */
+ ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00002000 /* configuration space */
+ 0x81000000 0 0 0x40002000 0 0x00010000 /* downstream I/O */
+ 0x82000000 0 0x40012000 0x40012000 0 0x1ffee000>; /* non-prefetchable memory */
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0x0 0 &gic 53>;
@@ -302,9 +302,9 @@
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
- ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00001000 /* configuration space */
- 0x81000000 0 0 0x60001000 0 0x00010000 /* downstream I/O */
- 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; /* non-prefetchable memory */
+ ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00002000 /* configuration space */
+ 0x81000000 0 0 0x60002000 0 0x00020000 /* downstream I/O */
+ 0x82000000 0 0x60012000 0x60012000 0 0x1ffee000>; /* non-prefetchable memory */
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0x0 0 &gic 56>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440
2014-04-01 2:54 [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440 Jingoo Han
@ 2014-04-01 3:43 ` Pratyush Anand
2014-04-01 3:58 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Anand @ 2014-04-01 3:43 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Kukjin Kim', linux-samsung-soc@vger.kernel.org,
linux-pci@vger.kernel.org
On Tue, Apr 01, 2014 at 10:54:57AM +0800, Jingoo Han wrote:
> Increase the size of PCIe configuration space to 8kB from 4kB,
> because 4kB for cfg0 and 4kB for cfg1 are required respectively.
> If 2kB for cfg0 and 2kB for cfg1 are set, it will make problems
> when a PCIe card having multiple EPs below a bridge is used.
>
> Suggested-by: Pratyush Anand <pratyush.anand@st.com>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/boot/dts/exynos5440.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index d600733..5d08be8 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -281,9 +281,9 @@
> #address-cells = <3>;
> #size-cells = <2>;
> device_type = "pci";
> - ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00001000 /* configuration space */
> - 0x81000000 0 0 0x40001000 0 0x00010000 /* downstream I/O */
> - 0x82000000 0 0x40011000 0x40011000 0 0x1ffef000>; /* non-prefetchable memory */
> + ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00002000 /* configuration space */
> + 0x81000000 0 0 0x40002000 0 0x00010000 /* downstream I/O */
> + 0x82000000 0 0x40012000 0x40012000 0 0x1ffee000>; /* non-prefetchable memory */
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0>;
> interrupt-map = <0x0 0 &gic 53>;
> @@ -302,9 +302,9 @@
> #address-cells = <3>;
> #size-cells = <2>;
> device_type = "pci";
> - ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00001000 /* configuration space */
> - 0x81000000 0 0 0x60001000 0 0x00010000 /* downstream I/O */
> - 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; /* non-prefetchable memory */
> + ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00002000 /* configuration space */
> + 0x81000000 0 0 0x60002000 0 0x00020000 /* downstream I/O */
is I/O size change intentional?
Regards
Pratyush
> + 0x82000000 0 0x60012000 0x60012000 0 0x1ffee000>; /* non-prefetchable memory */
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0>;
> interrupt-map = <0x0 0 &gic 56>;
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440
2014-04-01 3:43 ` Pratyush Anand
@ 2014-04-01 3:58 ` Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2014-04-01 3:58 UTC (permalink / raw)
To: 'Pratyush Anand'
Cc: 'Kukjin Kim', linux-samsung-soc, linux-pci,
'Jingoo Han'
On Tuesday, April 01, 2014 12:44 PM, Pratyush Anand wrote:
> On Tue, Apr 01, 2014 at 10:54:57AM +0800, Jingoo Han wrote:
> > Increase the size of PCIe configuration space to 8kB from 4kB,
> > because 4kB for cfg0 and 4kB for cfg1 are required respectively.
> > If 2kB for cfg0 and 2kB for cfg1 are set, it will make problems
> > when a PCIe card having multiple EPs below a bridge is used.
> >
> > Suggested-by: Pratyush Anand <pratyush.anand@st.com>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos5440.dtsi | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> > index d600733..5d08be8 100644
> > --- a/arch/arm/boot/dts/exynos5440.dtsi
> > +++ b/arch/arm/boot/dts/exynos5440.dtsi
> > @@ -281,9 +281,9 @@
> > #address-cells = <3>;
> > #size-cells = <2>;
> > device_type = "pci";
> > - ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00001000 /* configuration space */
> > - 0x81000000 0 0 0x40001000 0 0x00010000 /* downstream I/O */
> > - 0x82000000 0 0x40011000 0x40011000 0 0x1ffef000>; /* non-prefetchable memory */
> > + ranges = <0x00000800 0 0x40000000 0x40000000 0 0x00002000 /* configuration space */
> > + 0x81000000 0 0 0x40002000 0 0x00010000 /* downstream I/O */
> > + 0x82000000 0 0x40012000 0x40012000 0 0x1ffee000>; /* non-prefetchable memory */
> > #interrupt-cells = <1>;
> > interrupt-map-mask = <0 0 0 0>;
> > interrupt-map = <0x0 0 &gic 53>;
> > @@ -302,9 +302,9 @@
> > #address-cells = <3>;
> > #size-cells = <2>;
> > device_type = "pci";
> > - ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00001000 /* configuration space */
> > - 0x81000000 0 0 0x60001000 0 0x00010000 /* downstream I/O */
> > - 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; /* non-prefetchable memory */
> > + ranges = <0x00000800 0 0x60000000 0x60000000 0 0x00002000 /* configuration space */
> > + 0x81000000 0 0 0x60002000 0 0x00020000 /* downstream I/O */
>
> is I/O size change intentional?
Hi Pratyush Anand,
No, it is my mistake. I/O size should not be modified.
I really appreciate your review. I will send v2 patch. :-)
Thank you.
Best regards,
Jingoo Han
>
> Regards
> Pratyush
> > + 0x82000000 0 0x60012000 0x60012000 0 0x1ffee000>; /* non-prefetchable memory */
> > #interrupt-cells = <1>;
> > interrupt-map-mask = <0 0 0 0>;
> > interrupt-map = <0x0 0 &gic 56>;
> > --
> > 1.7.10.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-01 3:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 2:54 [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440 Jingoo Han
2014-04-01 3:43 ` Pratyush Anand
2014-04-01 3:58 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).