Re: [PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

["Jingoo Han" <jingoohan1@gmail.com>]

On Wednesday, July 4, 2018 12:21 PM, Lorenzo Pieralisi wrote:
> 
> On Sun, Jul 01, 2018 at 11:54:43AM +0800, Shawn Guo wrote:
> > Function dw_pcie_host_init() already initializes the root_bus_nr field
> > of 'struct pcie_port', so the -1 assignment prior to calling
> > dw_pcie_host_init() in platform specific driver is not really needed.
> > Drop it.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Jingoo Han <jingoohan1@gmail.com>
> > ---
> >  drivers/pci/controller/dwc/pci-exynos.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Jingoo we would need your ACK here, thanks.

I am not sure that this patch is good.
Currently, this patch does not make any problem.
However, I prefer to keep checking codes unless it makes a lot of burden.
This is because we cannot ensure that flow of codes will not change in the
future.
However, if you think that it can be ensured that the problem will not
happen
in the future, please merge this patch.

Best regards,
Jingoo Han

> 
> Lorenzo
> 
> > diff --git a/drivers/pci/controller/dwc/pci-exynos.c
> b/drivers/pci/controller/dwc/pci-exynos.c
> > index 4cc1e5df8c79..cee5f2f590e2 100644
> > --- a/drivers/pci/controller/dwc/pci-exynos.c
> > +++ b/drivers/pci/controller/dwc/pci-exynos.c
> > @@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct
> exynos_pcie *ep,
> >  		}
> >  	}
> >
> > -	pp->root_bus_nr = -1;
> >  	pp->ops = &exynos_pcie_host_ops;
> >
> >  	ret = dw_pcie_host_init(pp);
> > --
> > 1.9.1
> >