From: Jingoo Han <jg1.han@samsung.com>
To: 'Gabriel FERNANDEZ' <gabriel.fernandez@st.com>
Cc: 'Arnd Bergmann' <arnd@arndb.de>,
'Rob Herring' <robh+dt@kernel.org>,
'Pawel Moll' <pawel.moll@arm.com>,
'Mark Rutland' <mark.rutland@arm.com>,
'Ian Campbell' <ijc+devicetree@hellion.org.uk>,
'Kumar Gala' <galak@codeaurora.org>,
'Srinivas Kandagatla' <srinivas.kandagatla@gmail.com>,
'Maxime Coquelin' <maxime.coquelin@st.com>,
'Patrice Chotard' <patrice.chotard@st.com>,
'Russell King' <linux@arm.linux.org.uk>,
'Bjorn Helgaas' <bhelgaas@google.com>,
'Mohit Kumar' <mohit.kumar@st.com>,
'Grant Likely' <grant.likely@linaro.org>,
'Gabriel Fernandez' <gabriel.fernandez@linaro.org>,
'Fabrice Gasnier' <fabrice.gasnier@st.com>,
'Viresh Kumar' <viresh.kumar@linaro.org>,
'Thierry Reding' <treding@nvidia.com>,
'Minghuan Lian' <Minghuan.Lian@freescale.com>,
'Magnus Damm' <damm@opensource.se>,
'Will Deacon' <will.deacon@arm.com>,
'Tanmay Inamdar' <tinamdar@apm.com>,
'Murali Karicheri' <m-karicheri2@ti.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>,
'Pratyush Anand' <pratyush.anand@st.com>,
'Sachin Kamat' <sachin.kamat@samsung.com>,
'Andrew Lunn' <andrew@lunn.ch>,
'Liviu Dudau' <Liviu.Dudau@arm.com>,
'Srikanth Thokala' <sthokal@xilinx.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
linux-pci@vger.kernel.org, 'Lee Jones' <lee.jones@linaro.org>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH 4/5] PCI: designware: Add setup bus-related to pcie_host_ops
Date: Thu, 18 Dec 2014 13:58:27 +0900 [thread overview]
Message-ID: <000e01d01a7f$47592e20$d60b8a60$%han@samsung.com> (raw)
In-Reply-To: <1507589.aeTeyNn1QF@wuerfel>
On Thursday, December 18, 2014 7:16 AM, Arnd Bergmann wrote:
> On Wednesday 17 December 2014 11:34:45 Gabriel FERNANDEZ wrote:
> > ST sti SoCs PCIe IPs are built around DesignWare IP Core.
> > But in these SoCs PCIe IP doesn't support IO.
Hi Gabriel,
I cannot understand how ST sti SoCs PCIe IP does not support I/O.
As far as I know, it cannot be selected by the 'parameter'.
Then, H/W engineers dropped out the I/O control logic?
> >
> > To support this, add setup_bus() to pcie_host_ops.
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
>
> The dw-pcie driver should be able to tell whether the device has
> an I/O space or not, and do the right thing based on that. Don't
> add an implementation specific callback for that.
I agree with Arnd's opinion.
In addition, I have one more question.
Then, if a device that requires I/O region is connected to
PCIe slot of ST sti SoCs PCIe, what will happen?
It just prints error messages?
Best regards,
Jingoo Han
>
> Arnd
next prev parent reply other threads:[~2014-12-18 4:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 10:34 [PATCH 0/5] PCI: st: provide support for dw pcie Gabriel FERNANDEZ
2014-12-17 10:34 ` [PATCH 1/5] ARM: STi: Kconfig update for PCIe support Gabriel FERNANDEZ
2014-12-17 10:34 ` [PATCH 2/5] PCI: st: Add Device Tree bindings for sti pcie Gabriel FERNANDEZ
2014-12-17 22:01 ` Arnd Bergmann
2015-01-19 13:04 ` Gabriel Fernandez
2014-12-22 4:45 ` Pratyush Anand
2014-12-17 10:34 ` [PATCH 3/5] PCI: st: Provide support for the sti PCIe controller Gabriel FERNANDEZ
2014-12-17 22:14 ` Arnd Bergmann
2015-01-19 13:08 ` Gabriel Fernandez
[not found] ` <CAG374jDmUyEX0_iu4wG8LjM6YGMjsB-3PjnyZy_0Se=nLcn16g@mail.gmail.com>
2015-01-19 13:49 ` Arnd Bergmann
2015-01-21 15:47 ` Gabriel Fernandez
2015-01-21 19:35 ` Arnd Bergmann
2015-01-21 19:59 ` Lucas Stach
2014-12-18 6:03 ` Jingoo Han
2015-01-19 13:06 ` Gabriel Fernandez
2014-12-22 5:12 ` Pratyush Anand
2015-01-12 18:43 ` Bjorn Helgaas
2015-01-21 15:32 ` Gabriel Fernandez
2014-12-17 10:34 ` [PATCH 4/5] PCI: designware: Add setup bus-related to pcie_host_ops Gabriel FERNANDEZ
2014-12-17 22:16 ` Arnd Bergmann
2014-12-18 4:58 ` Jingoo Han [this message]
2015-01-19 13:09 ` Gabriel Fernandez
[not found] ` <CAG374jBZCn+V2zjcAwdKEb0COzBT2VES5uiw0gc40mFvoraERA@mail.gmail.com>
2015-01-19 13:54 ` Arnd Bergmann
2015-01-19 15:46 ` Lorenzo Pieralisi
2014-12-17 10:34 ` [PATCH 5/5] PCI: st: disable IO support Gabriel FERNANDEZ
2014-12-17 14:01 ` One Thousand Gnomes
2015-01-21 15:49 ` Gabriel Fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01d01a7f$47592e20$d60b8a60$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Liviu.Dudau@arm.com \
--cc=Minghuan.Lian@freescale.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=damm@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gabriel.fernandez@linaro.org \
--cc=gabriel.fernandez@st.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=maxime.coquelin@st.com \
--cc=mohit.kumar@st.com \
--cc=patrice.chotard@st.com \
--cc=pawel.moll@arm.com \
--cc=pratyush.anand@st.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=sthokal@xilinx.com \
--cc=tinamdar@apm.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).