From: "Pankaj Dubey" <pankaj.dubey@samsung.com>
To: "'Christoph Hellwig'" <hch@infradead.org>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bhelgaas@google.com>, <andrew.murray@arm.com>,
<lorenzo.pieralisi@arm.com>, <gustavo.pimentel@synopsys.com>,
<jingoohan1@gmail.com>, <vidyas@nvidia.com>,
"'Anvesh Salveru'" <anvesh.s@samsung.com>
Subject: RE: [PATCH v3] PCI: dwc: Add support to add GEN3 related equalization quirks
Date: Tue, 15 Oct 2019 20:47:32 +0530 [thread overview]
Message-ID: <000e01d5836b$ac871190$059534b0$@samsung.com> (raw)
In-Reply-To: <20191015090547.GA7199@infradead.org>
> -----Original Message-----
> From: 'Christoph Hellwig' <hch@infradead.org>
> Sent: Tuesday, October 15, 2019 2:36 PM
> To: Pankaj Dubey <pankaj.dubey@samsung.com>
> Cc: 'Christoph Hellwig' <hch@infradead.org>; linux-pci@vger.kernel.org;
linux-
> kernel@vger.kernel.org; bhelgaas@google.com; andrew.murray@arm.com;
> lorenzo.pieralisi@arm.com; gustavo.pimentel@synopsys.com;
> jingoohan1@gmail.com; vidyas@nvidia.com; 'Anvesh Salveru'
> <anvesh.s@samsung.com>
> Subject: Re: [PATCH v3] PCI: dwc: Add support to add GEN3 related
equalization
> quirks
>
> On Tue, Oct 15, 2019 at 02:28:00PM +0530, Pankaj Dubey wrote:
> > Is this something mandatory?
> >
> > As we discussed during first patch-set here [1] with Andrew, we have
> > need of this patch (along with some other stuffs, which will be sent
> > soon), to clean up our internal driver and make it ready for upstream.
> > As of today we have some internal restrictions where we can't make it
> > to upstream along with this patch.
>
> We don't add code to the kernel without actual users.
OK, but do we think the current driver has only code which is being used by
some user?
At least I can see current driver has some features which is not being used
by any current driver.
I will leave this call up-to the maintainers.
IMO, This being an DWC H/W IP feature, for me it makes sense to have it in
DWC controller driver as long as it does not break any existing
functionality, irrespective of actual user is present or not.
next prev parent reply other threads:[~2019-10-15 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191015025933epcas5p1f0891dacc13648559ed8e037e49ee5b1@epcas5p1.samsung.com>
2019-10-15 2:59 ` [PATCH v3] PCI: dwc: Add support to add GEN3 related equalization quirks Pankaj Dubey
2019-10-15 8:16 ` Christoph Hellwig
2019-10-15 8:58 ` Pankaj Dubey
2019-10-15 9:05 ` 'Christoph Hellwig'
2019-10-15 15:17 ` Pankaj Dubey [this message]
2019-10-16 6:52 ` 'Christoph Hellwig'
2019-10-16 14:44 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01d5836b$ac871190$059534b0$@samsung.com' \
--to=pankaj.dubey@samsung.com \
--cc=andrew.murray@arm.com \
--cc=anvesh.s@samsung.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hch@infradead.org \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).