From: Jingoo Han <jg1.han@samsung.com>
To: 'Thomas Petazzoni' <thomas.petazzoni@free-electrons.com>,
'Fabio Estevam' <fabio.estevam@freescale.com>
Cc: 'Fabio Estevam' <festevam@gmail.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type
Date: Tue, 29 Apr 2014 14:53:07 +0900 [thread overview]
Message-ID: <001301cf636f$4bba6460$e32f2d20$%han@samsung.com> (raw)
In-Reply-To: <20140429074559.5c6970fd@skate>
On Tuesday, April 29, 2014 2:46 PM, Thomas Petazzoni wrote:
> On Tue, 29 Apr 2014 00:24:56 -0300, Fabio Estevam wrote:
>
> > if (ret) {
> > dev_err(&port->pcie->pdev->dev,
> > - "Could not create MBus window at 0x%x, size 0x%x: %d\n",
> > - base, sz, ret);
> > + "Could not create MBus window at [mem %pa - %pa] :%d\n",
> > + &base, &base + sz, ret);
>
> Are you sure '&base + sz' works here? %pa needs a reference as
> argument, so &base looks good. But '&base + sz' means you will print
> the value which is at the address of base, to which 'sz' is added,
> which is not what we want here. Probably you need something like:
>
> phys_addr_t end = base + sz;
>
> and then use '&end'.
>
> Or I am missing something?
I agree with your suggestion.
Thanks.
Best regards,
Jingoo Han
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
prev parent reply other threads:[~2014-04-29 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 3:24 [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type Fabio Estevam
2014-04-29 5:35 ` Jingoo Han
2014-04-29 5:45 ` Thomas Petazzoni
2014-04-29 5:53 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001301cf636f$4bba6460$e32f2d20$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).