linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Joao Pinto'" <Joao.Pinto@synopsys.com>, <bhelgaas@google.com>,
	<marc.zyngier@arm.com>
Cc: <m-karicheri2@ti.com>, <thomas.petazzoni@free-electrons.com>,
	<minghuan.Lian@freescale.com>, <mingkai.hu@freescale.com>,
	<tie-fei.zang@freescale.com>, <hongxing.zhu@nxp.com>,
	<l.stach@pengutronix.de>, <niklas.cassel@axis.com>,
	<jesper.nilsson@axis.com>, <wangzhou1@hisilicon.com>,
	<gabriele.paoloni@huawei.com>, <svarbanov@mm-sol.com>,
	<linux-pci@vger.kernel.org>
Subject: Re: [RFC v2 2/8] pci: exynos SoC driver adapted to new irq API
Date: Thu, 18 May 2017 14:50:13 -0400	[thread overview]
Message-ID: <002a01d2d007$9651afd0$c2f50f70$@gmail.com> (raw)
In-Reply-To: <f395077bae8e34b2929bccb886952322ad5526fc.1494867112.git.jpinto@synopsys.com>

On Monday, May 15, 2017 1:04 PM, Joao Pinto wrote:

> 
> This patch adapts Exynos SoC specific driver to use the new interrupt api
> available in pcie-designware.
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
> changes v1->v2:
> - just to keep up patch set version
> 
>  drivers/pci/dwc/pci-exynos.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
> index 546082a..e49c39a 100644
> --- a/drivers/pci/dwc/pci-exynos.c
> +++ b/drivers/pci/dwc/pci-exynos.c
> @@ -490,15 +490,6 @@ static irqreturn_t exynos_pcie_irq_handler(int irq,
> void *arg)
>  	return IRQ_HANDLED;
>  }
> 
> -static irqreturn_t exynos_pcie_msi_irq_handler(int irq, void *arg)
> -{
> -	struct exynos_pcie *ep = arg;
> -	struct dw_pcie *pci = ep->pci;
> -	struct pcie_port *pp = &pci->pp;
> -
> -	return dw_handle_msi_irq(pp);
> -}
> -
>  static void exynos_pcie_msi_init(struct exynos_pcie *ep)
>  {
>  	struct dw_pcie *pci = ep->pci;
> @@ -622,15 +613,6 @@ static int __init exynos_add_pcie_port(struct
> exynos_pcie *ep,
>  			dev_err(dev, "failed to get msi irq\n");
>  			return -ENODEV;
>  		}
> -
> -		ret = devm_request_irq(dev, pp->msi_irq,
> -					exynos_pcie_msi_irq_handler,
> -					IRQF_SHARED | IRQF_NO_THREAD,
> -					"exynos-pcie", ep);
> -		if (ret) {
> -			dev_err(dev, "failed to request msi irq\n");
> -			return ret;
> -		}
>  	}
> 
>  	pp->root_bus_nr = -1;
> --
> 2.9.3

  reply	other threads:[~2017-05-18 18:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 17:03 [RFC v2 0/8] add new irq api to pcie-designware Joao Pinto
2017-05-15 17:03 ` [RFC v2 1/8] pci: adding new irq api to pci-designware Joao Pinto
2017-05-21  8:44   ` Marc Zyngier
2017-05-22  9:24     ` Joao Pinto
2017-05-15 17:03 ` [RFC v2 2/8] pci: exynos SoC driver adapted to new irq API Joao Pinto
2017-05-18 18:50   ` Jingoo Han [this message]
2017-05-15 17:03 ` [RFC v2 3/8] pci: imx6 " Joao Pinto
2017-05-15 17:03 ` [RFC v2 4/8] pci: artpec6 " Joao Pinto
2017-05-15 17:03 ` [RFC v2 5/8] pci: generic PCIe DW " Joao Pinto
2017-05-15 17:03 ` [RFC v2 6/8] pci: qcom SoC " Joao Pinto
2017-05-15 17:03 ` [RFC v2 7/8] pci: keystone " Joao Pinto
2017-05-15 17:03 ` [RFC v2 8/8] pci: removing old irq api from pcie-designware Joao Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002a01d2d007$9651afd0$c2f50f70$@gmail.com' \
    --to=jingoohan1@gmail.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=gabriele.paoloni@huawei.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=jesper.nilsson@axis.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=marc.zyngier@arm.com \
    --cc=minghuan.Lian@freescale.com \
    --cc=mingkai.hu@freescale.com \
    --cc=niklas.cassel@axis.com \
    --cc=svarbanov@mm-sol.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tie-fei.zang@freescale.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).