From: Jingoo Han <jg1.han@samsung.com>
To: 'Bjorn Helgaas' <bhelgaas@google.com>
Cc: 'Mohit KUMAR DCG' <Mohit.KUMAR@st.com>,
'Harro Haan' <hrhaan@gmail.com>, 'Marek Vasut' <marex@denx.de>,
'Richard Zhu' <hong-xing.zhu@freescale.com>,
'Shawn Guo' <shawn.guo@linaro.org>,
'Pratyush ANAND' <pratyush.anand@st.com>,
'Tim Harvey' <tharvey@gateworks.com>,
'Juergen Beisert' <jbe@pengutronix.de>,
'Arnd Bergmann' <arnd@arndb.de>,
'Siva Reddy Kallam' <siva.kallam@samsung.com>,
'Srikanth T Shivanand' <ts.srikanth@samsung.com>,
'Sean Cross' <xobs@kosagi.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] pci: designware: fix missing msi irqs
Date: Fri, 20 Dec 2013 11:41:56 +0900 [thread overview]
Message-ID: <003201cefd2d$0c7cbc60$25763520$%han@samsung.com> (raw)
In-Reply-To: <2CC2A0A4A178534D93D5159BF3BCB66189F95F6A22@EAPEX1MAIL1.st.com>
On Monday, December 16, 2013 3:49 PM, Mohit KUMAR DCG wrote:
> On Monday, December 16, 2013 6:24 AM, Jingoo Han wrote:
> > On Friday, December 13, 2013 3:29 AM, Harro Haan wrote:
> > >
> > > The interrupts were cleared after the irq handler was called.
> > > This means that new interrupts that occur after the handler handled
> > > the previous irq but before the interrupt is cleared will be missed.
> > >
> > > Signed-off-by: Harro Haan <hrhaan@gmail.com>
> > > Cc: Mohit Kumar <mohit.kumar@st.com>
> > > Cc: Jingoo Han <jg1.han@samsung.com>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: Marek Vasut <marex@denx.de>
> > > Cc: Richard Zhu <hong-xing.zhu@freescale.com>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Pratyush Anand <pratyush.anand@st.com>
> > > Cc: Tim Harvey <tharvey@gateworks.com>
> > > Cc: Juergen Beisert <jbe@pengutronix.de>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
> > > Cc: Srikanth T Shivanand <ts.srikanth@samsung.com>
> > > Cc: Sean Cross <xobs@kosagi.com>
> > > Cc: linux-pci@vger.kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> >
> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >
> > I was not able to reproduce the problem, however it looks good. Also, there
> > is no side effect on Exynos platform.
> >
> > Mohit,
> > If you have some comments, please let us know.
>
> - Quickly tested on SPEAr1310, working fine without any side effect. So is,
> Acked-by: Mohit Kumar <mohit.kumar@st.com>
Hi Bjorn Helgaas,
Would you apply this patch to your 'pci/host-designware' branch
with the following Tested-by and Acked-by?
Tested-by: Marek Vasut <marex@denx.de>
Tested-by: Matthias Mann <m.mann@arkona-technologies.de>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Mohit Kumar <mohit.kumar@st.com>
> ..
> >
> > > ---
> > > drivers/pci/host/pcie-designware.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2013-12-20 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131212182903.409515738@gmail.com>
2013-12-12 19:29 ` [PATCH] pci: designware: fix missing msi irqs Matthias Mann
2013-12-13 8:42 ` Matthias Mann
2013-12-12 22:01 ` Marek Vasut
2013-12-16 0:54 ` Jingoo Han
2013-12-16 6:48 ` Mohit KUMAR DCG
2013-12-20 2:41 ` Jingoo Han [this message]
2013-12-20 16:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003201cefd2d$0c7cbc60$25763520$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Mohit.KUMAR@st.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=hong-xing.zhu@freescale.com \
--cc=hrhaan@gmail.com \
--cc=jbe@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=marex@denx.de \
--cc=pratyush.anand@st.com \
--cc=shawn.guo@linaro.org \
--cc=siva.kallam@samsung.com \
--cc=tharvey@gateworks.com \
--cc=ts.srikanth@samsung.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox