From: Jingoo Han <jg1.han@samsung.com>
To: 'Bjorn Helgaas' <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] PCI: PCIe portdrv: use DEFINE_PCI_DEVICE_TABLE macro
Date: Thu, 28 Nov 2013 13:38:10 +0900 [thread overview]
Message-ID: <005501ceebf3$a4692ea0$ed3b8be0$%han@samsung.com> (raw)
In-Reply-To: <002801ceebe7$a0293170$e07b9450$%han@samsung.com>
On Thursday, November 28, 2013 12:12 PM, Jingoo Han wrote:
>
> This macro is used to create a struct pci_device_id array.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Please, ignore this patch.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.
Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches."
So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
Sorry for annoying. :-)
Best regards,
Jingoo Han
> ---
> drivers/pci/pcie/portdrv_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 0d8fdc4..5356902 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -368,7 +368,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
> /*
> * LINUX Device Driver Model
> */
> -static const struct pci_device_id port_pci_ids[] = { {
> +static DEFINE_PCI_DEVICE_TABLE(port_pci_ids) = { {
> /* handle any PCI-Express port */
> PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0),
> }, { /* end: all zeroes */ }
> --
> 1.7.10.4
prev parent reply other threads:[~2013-11-28 4:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 3:12 [PATCH] PCI: PCIe portdrv: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 4:38 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005501ceebf3$a4692ea0$ed3b8be0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).