From: "Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics" <aman1.gupta@samsung.com>
To: "'Shunsuke Mie'" <mie@igel.co.jp>, <shradha.t@samsung.com>,
<pankaj.dubey@samsung.com>, <kishon@ti.com>,
<lpieralisi@kernel.org>, <kw@linux.com>, <shuah@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
"'Padmanabhan Rajanbabu'" <p.rajanbabu@samsung.com>
Subject: RE: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint driver test
Date: Fri, 23 Dec 2022 19:09:11 +0530 [thread overview]
Message-ID: <00fa01d916d3$f1ef90a0$d5ceb1e0$@samsung.com> (raw)
In-Reply-To: <7d982a83-a841-ca56-20cc-cb5373a4bcdc@igel.co.jp>
> -----Original Message-----
> From: Shunsuke Mie [mailto:mie@igel.co.jp]
> Sent: 21 December 2022 14:00
> To: Aman Gupta <aman1.gupta@samsung.com>; shradha.t@samsung.com;
> pankaj.dubey@samsung.com; kishon@ti.com; lpieralisi@kernel.org;
> kw@linux.com; shuah@kernel.org
> Cc: linux-pci@vger.kernel.org; linux-kselftest@vger.kernel.org;
> Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
> Subject: Re: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint
> driver test
>
> Hi Aman,
>
> It is a nice work.
>
> On 2022/10/07 14:39, Aman Gupta wrote:
> > This patch enables the support to perform selftest on PCIe endpoint
> > driver present in the system. The following tests are currently
> > performed by the selftest utility
> >
> > 1. BAR Tests (BAR0 to BAR5)
> > 2. MSI Interrupt Tests (MSI1 to MSI32) 3. Read Tests (For 1, 1024,
> > 1025, 1024000, 1024001 Bytes) 4. Write Tests (For 1, 1024, 1025,
> > 1024000, 1024001 Bytes) 5. Copy Tests (For 1, 1024, 1025, 1024000,
> > 1024001 Bytes)
> >
> > Signed-off-by: Aman Gupta <aman1.gupta@samsung.com>
> > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
> > ---
> > tools/testing/selftests/Makefile | 1 +
> > tools/testing/selftests/pci/.gitignore | 1 +
> > tools/testing/selftests/pci/Makefile | 7 +
> > tools/testing/selftests/pci/pci-selftest.c | 167
> > +++++++++++++++++++++
> This test is for a pci endpoint test driver. so I think it should be located on
> tools/testing/selftest/drivers/pci/endpoint. What do you think?
Hi Shunsuke,
Thanks for the review and nice thought about relocating the file.
As per the review provided by Manivanan, I will be changing the name of the file to endpoint-test.c
and hence I am thinking to move this file to tools/testing/selftest/driver/pci/endpoint_test.c
Thanks,
Aman Gupta
next prev parent reply other threads:[~2022-12-26 5:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221007053726epcas5p357c35abb79327fee6327bc6493e0178c@epcas5p3.samsung.com>
2022-10-07 5:39 ` [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint driver test Aman Gupta
2022-10-11 10:58 ` Kishon Vijay Abraham I
2022-10-21 6:56 ` Aman Gupta
2022-10-21 8:00 ` 'Manivannan Sadhasivam'
2022-11-01 14:02 ` Manivannan Sadhasivam
2022-11-01 17:19 ` Manivannan Sadhasivam
2022-12-21 8:30 ` Shunsuke Mie
2022-12-23 13:39 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics [this message]
2022-12-22 16:58 ` Shuah Khan
2022-12-22 17:45 ` Manivannan Sadhasivam
2022-12-22 17:49 ` Shuah Khan
2022-12-23 15:02 ` Manivannan Sadhasivam
2022-12-23 16:31 ` Shuah Khan
2022-12-27 5:15 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics
2023-01-17 19:59 ` Bjorn Helgaas
2023-01-26 20:57 ` Shuah Khan
2023-02-14 6:16 ` 'Manivannan Sadhasivam'
2023-03-08 11:06 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics
2023-01-17 8:12 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics
[not found] <CGME20221219043044epcas5p3d5476a9a5d6ae7a5cd2bb3fa92708e73@epcas5p3.samsung.com>
2022-12-19 4:30 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics
2022-12-21 7:24 ` 'Manivannan Sadhasivam'
2022-12-23 13:45 ` Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fa01d916d3$f1ef90a0$d5ceb1e0$@samsung.com' \
--to=aman1.gupta@samsung.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mie@igel.co.jp \
--cc=p.rajanbabu@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=shradha.t@samsung.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).