linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Lukas Wunner" <lukas@wunner.de>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	linux-pci@vger.kernel.org, "mad skateman" <madskateman@gmail.com>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	"Christian Zigotzky" <info@xenosoft.de>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	hypexed@yahoo.com.au, "Darren Stevens" <darren@stevens-zone.net>,
	debian-powerpc@lists.debian.org
Subject: Re: [PPC] Boot problems after the pci-v6.18-changes
Date: Tue, 14 Oct 2025 06:55:07 +0200	[thread overview]
Message-ID: <00fe408b-db39-4a9f-b996-0fad73724759@xenosoft.de> (raw)
In-Reply-To: <a2ee06b1-28a5-4cb1-9940-b225f9e6d6ee@xenosoft.de>

On 13 October 2025 at 05:58 pm, Manivannan Sadhasivam wrote:
 > Either the Root Port could be triggering these AER messages due to 
ASPM issue or
 > due to the endpoint connected downstream.
 >
 > If possible, please share the whole dmesg log instead of the snippet 
so that we
 > can be sure from where the AER messages are coming from.
 >
 > You can also add the below quirk and check:
 >
 > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_FSL, 0x0451, 
quirk_disable_aspm_all);
 >
 > But it would be better to get the whole dmesg.
 >
 > - Mani

Hello Mani,

Thanks for your help.

The kernel doesn't compile with PCI_VENDOR_ID_FSL but it compiles with 
PCI_VENDOR_ID_FREESCALE.

I tried it with the following patch:

diff -rupN a/drivers/pci/quirks.c b/drivers/pci/quirks.c
--- a/drivers/pci/quirks.c    2025-10-12 22:42:36.000000000 +0200
+++ b/drivers/pci/quirks.c    2025-10-13 17:59:51.473097708 +0200
@@ -2525,6 +2525,16 @@ static void quirk_disable_aspm_l0s_l1(st
   */
  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, 
quirk_disable_aspm_l0s_l1);

+
+static void quirk_disable_aspm_all(struct pci_dev *dev)
+{
+       pci_info(dev, "Disabling ASPM\n");
+       pci_disable_link_state(dev, PCIE_LINK_STATE_ALL);
+}
+
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, 
quirk_disable_aspm_all);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, 
quirk_disable_aspm_all);
+
  /*
   * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
   * Link bit cleared after starting the link retrain process to allow this

---

Unfortunately it doesn't solve the issue with pcieport 0001:00:00.0.

Here is the dmesg of the RC1 of kernel 6.18 with this patch applied: 
https://github.com/user-attachments/files/22896410/dmesg_fsl_ppc.txt

Cyrus Plus block diagram: 
https://github.com/chzigotzky/kernels/issues/17#issuecomment-3400086860

Thanks,
Christian



  parent reply	other threads:[~2025-10-14  4:55 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3eedbe78-1fbd-4763-a7f3-ac5665e76a4a@xenosoft.de>
     [not found] ` <15731ad7-83ff-c7ef-e4a1-8b11814572c2@xenosoft.de>
     [not found]   ` <17e37b22-5839-0e3a-0dbf-9c676adb0dec@xenosoft.de>
     [not found]     ` <3b210c92-4be6-ce49-7512-bb194475eeab@xenosoft.de>
2021-11-09 15:10       ` [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates Christian Zigotzky
2021-11-09 16:58         ` Bjorn Helgaas
2021-11-09 22:40           ` Krzysztof Wilczyński
2021-11-09 23:05             ` Arnd Bergmann
2021-11-09 23:18               ` Krzysztof Wilczyński
2021-11-10 16:42                 ` Robert Święcki
2021-11-10  3:52             ` Damien Le Moal
2021-11-10 18:07       ` Christian Zigotzky
2021-11-10 18:41         ` Bjorn Helgaas
2021-11-10 19:09           ` Marc Zyngier
2021-11-11  5:24             ` Christian Zigotzky
2021-11-11  7:13               ` Marc Zyngier
2021-11-11  7:47                 ` Christian Zigotzky
2021-11-11 10:20                   ` Marc Zyngier
2021-11-11 10:44                     ` Christian Zigotzky
2021-11-11 11:24                       ` Marc Zyngier
2021-11-11 11:54                         ` Christian Zigotzky
2021-11-11 22:21                     ` Olof Johansson
2021-11-12 11:49                       ` Segher Boessenkool
2021-11-11 17:39         ` Marc Zyngier
2021-11-12  9:40           ` Christian Zigotzky
2021-11-12 10:11             ` Christian Zigotzky
2021-11-12 11:00               ` Christian Zigotzky
2021-11-12 13:41             ` Marc Zyngier
2021-11-12 14:15               ` Christian Zigotzky
2021-11-12 14:46                 ` Marc Zyngier
2021-11-12 15:01                   ` Christian Zigotzky
2021-11-12 15:05                     ` Christian Zigotzky
2025-10-08 16:35                       ` [PPC] Boot problems after the pci-v6.18-changes Christian Zigotzky
2025-10-08 16:40                         ` John Paul Adrian Glaubitz
2025-10-08 16:47                           ` Christian Zigotzky
2025-10-08 19:51                         ` Bjorn Helgaas
2025-10-09  4:54                           ` Christian Zigotzky
2025-10-09  5:37                             ` Lukas Wunner
2025-10-11  5:12                               ` Christian Zigotzky
2025-10-11  5:25                                 ` Lukas Wunner
2025-10-11 15:11                                   ` Manivannan Sadhasivam
2025-10-11 19:34                                     ` Christian Zigotzky
2025-10-12  7:47                                       ` Christian Zigotzky
2025-10-12  8:26                                         ` Christian Zigotzky
2025-10-13  4:46                                     ` Christian Zigotzky
2025-10-13  5:02                                       ` Christian Zigotzky
2025-10-13  5:23                                         ` Christian Zigotzky
2025-10-13 14:50                                           ` Christian Zigotzky
2025-10-13 15:02                                             ` Christian Zigotzky
2025-10-13 15:38                                               ` Christian Zigotzky
2025-10-13 15:58                                             ` Manivannan Sadhasivam
     [not found]                                               ` <a2ee06b1-28a5-4cb1-9940-b225f9e6d6ee@xenosoft.de>
2025-10-14  4:55                                                 ` Christian Zigotzky [this message]
2025-10-15  6:41                                                   ` Manivannan Sadhasivam
2025-10-13 16:01                                         ` Manivannan Sadhasivam
2025-10-15  8:13                                     ` Herve Codina
2025-10-15 11:30                                       ` Christian Zigotzky
2025-10-15 11:58                                         ` Herve Codina
2025-10-15 12:27                                           ` Christian Zigotzky
2025-10-15 12:59                                             ` Herve Codina
     [not found]                                               ` <76026544-3472-4953-910A-376DD42BC6D0@xenosoft.de>
2025-10-15 13:17                                                 ` Christian Zigotzky
2025-10-15 13:34                                                 ` Herve Codina
2025-10-15 16:54                                                   ` Christian Zigotzky
2025-10-15 17:15                                                     ` Christian Zigotzky
2025-10-16  3:28                                                   ` Christian Zigotzky
2025-10-16  7:36                                                     ` Christian Zigotzky
2025-10-16  7:53                                                       ` Manivannan Sadhasivam
2025-10-16 10:44                                                         ` Christian Zigotzky
2025-10-17  5:35                                                           ` Christian Zigotzky
2025-10-15 16:23                                               ` Manivannan Sadhasivam
2025-10-15 13:07                                             ` Christian Zigotzky
2025-10-15 12:50                                           ` Manivannan Sadhasivam
2025-10-23  7:38                                             ` Herve Codina
2025-10-23  8:49                                               ` Manivannan Sadhasivam
2025-10-23  9:19                                                 ` Herve Codina
2025-10-23 16:59                                                   ` Bjorn Helgaas
2025-10-15 23:40                                       ` Bjorn Helgaas
2025-10-13 21:06                         ` Bjorn Helgaas
2025-10-14 18:51                           ` Bjorn Helgaas
2025-10-30 22:11                           ` Bjorn Helgaas
2025-11-01  5:39                             ` Christian Zigotzky
2025-11-01  7:59                               ` Christian Zigotzky
2025-11-01 17:06                                 ` Manivannan Sadhasivam
2025-11-03 18:28                                   ` Christian Zigotzky
2025-11-05 22:09                                     ` Bjorn Helgaas
2025-11-06  8:48                                       ` Hongxing Zhu
2025-11-06 18:25                                         ` Bjorn Helgaas
2025-11-07  2:26                                           ` Hongxing Zhu
2025-11-07  5:06                                       ` Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00fe408b-db39-4a9f-b996-0fad73724759@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=darren@stevens-zone.net \
    --cc=debian-powerpc@lists.debian.org \
    --cc=helgaas@kernel.org \
    --cc=hypexed@yahoo.com.au \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=info@xenosoft.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=madskateman@gmail.com \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=rtd2@xtra.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).