[PATCH v4 0/2] PCI: qcom: sc7280: add missing aggre0 and aggre1 clocks

[PATCH v4 0/2] PCI: qcom: sc7280: add missing aggre0 and aggre1 clocks

[Krishna chaitanya chundru]

Add missing aggre0 and aggre1 clocks supports to PCIe node.

Without voting these clocks, PCIe link is going down when system is
suspended as these clocks can get turned off as no-one is voting for them.

Krishna chaitanya chundru (2):
  arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks
  dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks

 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++----
 arch/arm64/boot/dts/qcom/sc7280.dtsi                 |  8 ++++++--
 2 files changed, 12 insertions(+), 6 deletions(-)

-- 
2.7.4

[PATCH v4 1/2] arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks

[Krishna chaitanya chundru]

Add missing aggre0, aggre1 clocks.

Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
changes since v3:
	- Changed the order of the clocks added.
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index ad04025..357eae1 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2043,7 +2043,9 @@
 				 <&gcc GCC_PCIE_1_SLV_AXI_CLK>,
 				 <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>,
 				 <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>,
-				 <&gcc GCC_DDRSS_PCIE_SF_CLK>;
+				 <&gcc GCC_DDRSS_PCIE_SF_CLK>,
+				 <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>,
+				 <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>;
 
 			clock-names = "pipe",
 				      "pipe_mux",
@@ -2055,7 +2057,9 @@
 				      "bus_slave",
 				      "slave_q2a",
 				      "tbu",
-				      "ddrss_sf_tbu";
+				      "ddrss_sf_tbu",
+				      "aggre0",
+				      "aggre1";
 
 			assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>;
 			assigned-clock-rates = <19200000>;
-- 
2.7.4

Re: [PATCH v4 1/2] arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks

[Krzysztof Kozlowski]

On 08/09/2022 10:46, Krishna chaitanya chundru wrote:
> Add missing aggre0, aggre1 clocks.
> 
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> changes since v3:


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH v4 2/2] dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks

[Krishna chaitanya chundru]

Add missing aggre0 and aggre1 clocks.

Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
changes since v3:
	- Changed the order of the clocks.
---
 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 22a2aac..54f0785 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -56,11 +56,11 @@ properties:
   # Platform constraints are described later.
   clocks:
     minItems: 3
-    maxItems: 12
+    maxItems: 13
 
   clock-names:
     minItems: 3
-    maxItems: 12
+    maxItems: 13
 
   resets:
     minItems: 1
@@ -427,8 +427,8 @@ allOf:
     then:
       properties:
         clocks:
-          minItems: 11
-          maxItems: 11
+          minItems: 13
+          maxItems: 13
         clock-names:
           items:
             - const: pipe # PIPE clock
@@ -442,6 +442,8 @@ allOf:
             - const: slave_q2a # Slave Q2A clock
             - const: tbu # PCIe TBU clock
             - const: ddrss_sf_tbu # PCIe SF TBU clock
+            - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock
+            - const: aggre1 # Aggre NoC PCIe1 AXI clock
         resets:
           maxItems: 1
         reset-names:
-- 
2.7.4

Re: [PATCH v4 2/2] dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks

[Krzysztof Kozlowski]

On 08/09/2022 10:46, Krishna chaitanya chundru wrote:
> Add missing aggre0 and aggre1 clocks.
> 
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> changes since v3:
> 	- Changed the order of the clocks.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH v4 0/2] PCI: qcom: sc7280: add missing aggre0 and aggre1 clocks

[Bjorn Andersson]

On Thu, 8 Sep 2022 14:16:14 +0530, Krishna chaitanya chundru wrote:
> Add missing aggre0 and aggre1 clocks supports to PCIe node.
> 
> Without voting these clocks, PCIe link is going down when system is
> suspended as these clocks can get turned off as no-one is voting for them.
> 
> Krishna chaitanya chundru (2):
>   arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks
>   dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks
      commit: aaf85b46aa4145f5ec7aa0a9bdf4a93b23474524
[2/2] dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks
      commit: a672a9f4a6bba31f8dfb3a77714468ddb985ecf7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH v4 0/2] PCI: qcom: sc7280: add missing aggre0 and aggre1 clocks

[Lorenzo Pieralisi]

On Thu, 8 Sep 2022 14:16:14 +0530, Krishna chaitanya chundru wrote:
> Add missing aggre0 and aggre1 clocks supports to PCIe node.
> 
> Without voting these clocks, PCIe link is going down when system is
> suspended as these clocks can get turned off as no-one is voting for them.
> 
> Krishna chaitanya chundru (2):
>   arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks
>   dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks
> 
> [...]

Applied to pci/dt - dts changes (patch 1) should go via
platform tree, thanks!

[2/2] dt-bindings: pci: QCOM Add missing sc7280 aggre0, aggre1 clocks
      https://git.kernel.org/lpieralisi/pci/c/1abbe04a1b55

Thanks,
Lorenzo