From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F91914A85; Mon, 5 Aug 2024 04:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722830598; cv=none; b=YNre0p01JvBUFhg8dcQ2nbNYGExbsJP1X2yHmRv+dUsO7HbBQ+z93DAK/N2LTFW2qd+dz3SY+FAeT/KWfjC3Z+dtOSazpUtr8rdb/prrw57Ii7rR80RiP3rqp0LwEzEckL9AawlBX/5EukkfSfDAkXrBJNtw1PKsycU/XZ8Ufgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722830598; c=relaxed/simple; bh=KTlsVyhr5w6HgAt61sEulsGD/UsfqKxfY2iA8TxKdN8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oICGSV9j+9upavcxuJMIiEjGrzXK30irG+WfNxNtIx4u+KcphSEehII4suaIrNouS89haNUm+KeMvaB29XmKIn+8P45qOhUx8inYodKqp3j7ykDyN6gjLoproTJKO+ZZgja6rmSQdcyRXqef9szrXxoLUTL++BC87sBFldqNsH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=fPXwDOPA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="fPXwDOPA" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4752VUhA011325; Mon, 5 Aug 2024 04:03:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wGD4h/C5Z6m4l+vaJ1P68Rr3p5wdr/j4c5H3AJU3JKc=; b=fPXwDOPAzZtZPKPj QA7UXlcv/LdmIoqr165h6wiYqE1huLa9bcdgc3KOxKEiIcS+MKBhT/K7Dtd2CSNX Hqd+j1AwcMXHmz+M8kGVE8TKVxA6sQGvDJF5SpLNKQpFzTYScjTxI2WvtBmCbNXF IUZsEGIaJnA9yCMnfLKhixjzcYPTm99SZv5iqnlmnXmWHWnwg9F7oI90XcipTlf1 yHTqMm0VMCJ8fpbCGzu+upUlA7g+YZOkxCIcJVa866OkHZlGWozet4zcHzBD/Izc hRjgL6nib2M239KBkNYkOCdohlhg4ZEL9Z2Qgh/NKxkDIEgA9GZ4gsqobjcMv8GD +sYHXg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40scx6jrn7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Aug 2024 04:03:05 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 475434Wi030649 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Aug 2024 04:03:04 GMT Received: from [10.216.50.161] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 4 Aug 2024 21:02:58 -0700 Message-ID: <027dc9f7-6e0d-e331-8f90-92a3d56350ab@quicinc.com> Date: Mon, 5 Aug 2024 09:32:55 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/8] dt-bindings: PCI: Add binding for qps615 Content-Language: en-US To: Krzysztof Kozlowski , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , , Bartosz Golaszewski , Jingoo Han , Manivannan Sadhasivam CC: , , , , , , "Bartosz Golaszewski" References: <20240803-qps615-v2-0-9560b7c71369@quicinc.com> <20240803-qps615-v2-1-9560b7c71369@quicinc.com> <0cdaa0b2-ae50-40a1-abbb-7a6702d54ad5@kernel.org> From: Krishna Chaitanya Chundru In-Reply-To: <0cdaa0b2-ae50-40a1-abbb-7a6702d54ad5@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Pojx3rFs7umX47MPNCGk9_ZUtzK1C8Qd X-Proofpoint-GUID: Pojx3rFs7umX47MPNCGk9_ZUtzK1C8Qd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-04_14,2024-08-02_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1011 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408050026 On 8/4/2024 2:26 PM, Krzysztof Kozlowski wrote: > On 03/08/2024 05:22, Krishna chaitanya chundru wrote: >> Add binding describing the Qualcomm PCIe switch, QPS615, >> which provides Ethernet MAC integrated to the 3rd downstream port >> and two downstream PCIe ports. >> >> Signed-off-by: Krishna chaitanya chundru >> --- >> .../devicetree/bindings/pci/qcom,qps615.yaml | 191 +++++++++++++++++++++ >> 1 file changed, 191 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,qps615.yaml b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml >> new file mode 100644 >> index 000000000000..ea0c953ee56f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml >> @@ -0,0 +1,191 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/qcom,qps615.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm QPS615 PCIe switch >> + >> +maintainers: >> + - Krishna chaitanya chundru >> + >> +description: | >> + Qualcomm QPS615 PCIe switch has one upstream and three downstream >> + ports. The 3rd downstream port has integrated endpoint device of >> + Ethernet MAC. Other two downstream ports are supposed to connect >> + to external device. >> + >> + The QPS615 PCIe switch can be configured through I2C interface before >> + PCIe link is established to change FTS, ASPM related entry delays, >> + tx amplitude etc for better power efficiency and functionality. >> + >> +properties: >> + compatible: >> + enum: >> + - pci1179,0623 >> + >> + reg: >> + maxItems: 1 >> + >> + qcom,qps615-controller: > > and now I see that you totally ignored comments. Repeating the same over > and over is a waste of time. > >
> This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. >
> > > Best regards, > Krzysztof > Hi Krzysztof, In patch1 we are trying to add reference of i2c-adapter, you suggested to use i2c-bus for that. we got comments on the driver code not to use adapter and instead use i2c client reference. I felt i2c-bus is not ideal to represent i2c client device so used this name. I should have mentioned all these details in the change log for all these changes. Next time onwards I will give detailed change log for the changes between two versions. - Krishna Chaitanya.