From: Hemant Kumar <hemantk@codeaurora.org>
To: helgaas@kernel.org
Cc: linux-pci@vger.kernel.org, manivannan.sadhasivam@linaro.org
Subject: Revert "PCI/ASPM: Save/restore L1SS Capability for suspend/resume"
Date: Mon, 20 Sep 2021 15:11:30 -0700 [thread overview]
Message-ID: <06838361-0d2c-4a18-da04-6fb586ecd730@codeaurora.org> (raw)
Hi Bjorn,
Is there any plan to revisit the fix to allow L1SS CTRL1 and CTRL2 save
and restore to work with suspend and resume.
Referring to the lkml discussion
https://lore.kernel.org/linux-pci/20201228040513.GA611645@bjorn-Precision-5520/
A patch was shared, described as :-
"4257f7e008ea restores PCI_L1SS_CTL1, then PCI_L1SS_CTL2. I think it
should do those in the reverse order, since the Enable bits are in
PCI_L1SS_CTL1. It also restores L1SS state (potentially enabling
L1.x) before we restore the PCIe Capability (potentially enabling ASPM
as a whole). Those probably should also be in the other order."
We are planning to enable aspm driver, but without L1SS control register
save and restore, it gets disabled after resume.
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project
next reply other threads:[~2021-09-20 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 22:11 Hemant Kumar [this message]
2021-09-20 22:26 ` Revert "PCI/ASPM: Save/restore L1SS Capability for suspend/resume" Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06838361-0d2c-4a18-da04-6fb586ecd730@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).