From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"chaitanya chundru" <quic_krichai@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
"Jingoo Han" <jingoohan1@gmail.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
quic_vbadigan@quicnic.com, amitk@kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
jorge.ramirez@oss.qualcomm.com,
linux-arm-kernel@lists.infradead.org,
"Dmitry Baryshkov" <lumag@kernel.org>
Subject: Re: [PATCH v7 7/8] arm64: defconfig: Enable TC9563 PWRCTL driver
Date: Thu, 30 Oct 2025 09:08:56 +0530 [thread overview]
Message-ID: <06a9de6c-c9a7-4c5d-9be3-5c9c9b4a56cf@oss.qualcomm.com> (raw)
In-Reply-To: <jjbiamlcof6gttme3crotwyzsxtrguohaib73gcsaabpan5fqe@s5uroqqargti>
On 10/30/2025 5:34 AM, Dmitry Baryshkov wrote:
> On Wed, Oct 29, 2025 at 05:00:00PM +0530, Krishna Chaitanya Chundru wrote:
>> Enable TC9563 PCIe switch pwrctl driver by default. This is needed
>> to power the PCIe switch which is present in Qualcomm RB3gen2 platform.
>> Without this the switch will not powered up and we can't use the
>> endpoints connected to the switch.
>>
>> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>> ---
>> arch/arm64/configs/defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
> There is some broken logic in your commit order. How comes defconfig
> changes come before the driver which actually defines that Kconfig
> entry?
>
> Please reorder your patches _logically_:
> - DT bindings
> - driver changes
> - DTS changes
> - defconfig changes
Ack.
- Krishna Chaitanya.
>
next prev parent reply other threads:[~2025-10-30 3:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 11:29 [PATCH v7 0/8] PCI: Enable Power and configure the TC9563 PCIe switch Krishna Chaitanya Chundru
2025-10-29 11:29 ` [PATCH v7 1/8] dt-bindings: PCI: Add binding for Toshiba " Krishna Chaitanya Chundru
2025-10-30 6:55 ` Manivannan Sadhasivam
2025-10-29 11:29 ` [PATCH v7 2/8] arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node Krishna Chaitanya Chundru
2025-10-29 11:29 ` [PATCH v7 3/8] PCI: Add assert_perst() operation to control PCIe PERST# Krishna Chaitanya Chundru
2025-10-29 11:29 ` [PATCH v7 4/8] PCI: dwc: Add assert_perst() hook for dwc glue drivers Krishna Chaitanya Chundru
2025-10-29 11:29 ` [PATCH v7 5/8] PCI: dwc: Implement .assert_perst() hook Krishna Chaitanya Chundru
2025-10-29 11:29 ` [PATCH v7 6/8] PCI: qcom: Add support for assert_perst() Krishna Chaitanya Chundru
2025-10-29 11:30 ` [PATCH v7 7/8] arm64: defconfig: Enable TC9563 PWRCTL driver Krishna Chaitanya Chundru
2025-10-29 13:15 ` Bartosz Golaszewski
2025-10-30 3:38 ` Krishna Chaitanya Chundru
2025-10-30 6:59 ` Manivannan Sadhasivam
2025-10-30 0:04 ` Dmitry Baryshkov
2025-10-30 3:38 ` Krishna Chaitanya Chundru [this message]
2025-10-29 11:30 ` [PATCH v7 8/8] PCI: pwrctrl: Add power control driver for tc9563 Krishna Chaitanya Chundru
2025-10-29 13:08 ` Ilpo Järvinen
2025-10-30 4:04 ` Krishna Chaitanya Chundru
2025-10-29 23:23 ` [PATCH v7 0/8] PCI: Enable Power and configure the TC9563 PCIe switch Bjorn Helgaas
2025-10-30 0:07 ` Dmitry Baryshkov
2025-10-30 3:43 ` Krishna Chaitanya Chundru
2025-10-30 15:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a9de6c-c9a7-4c5d-9be3-5c9c9b4a56cf@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jingoohan1@gmail.com \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lumag@kernel.org \
--cc=mani@kernel.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_vbadigan@quicnic.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).