From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Lukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Sinan Kaya <okaya@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements
Date: Tue, 31 Jul 2018 10:13:22 -0500 [thread overview]
Message-ID: <07e51d4b-db10-a402-8f08-40f98a86f7ba@embeddedor.com> (raw)
In-Reply-To: <92c3c456edb461494d5c44e1ff6bab2711228ff1.1532754355.git.lukas@wunner.de>
On 07/28/2018 12:22 AM, Lukas Wunner wrote:
> Per Mika's request, add an explicit break to the last case of switch
> statements everywhere in pciehp to be more defensive towards future
> amendments.
>
> Per Gustavo's request, mark all non-empty implicit fallthroughs with a
> comment to silence warnings triggered by -Wimplicit-fallthrough=2.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-07-31 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 5:22 [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements Lukas Wunner
2018-07-28 5:22 ` [PATCH 2/2] PCI: pciehp: Deduplicate presence check on probe & resume Lukas Wunner
2018-07-31 8:03 ` Mika Westerberg
2018-07-31 21:22 ` Lukas Wunner
2018-07-31 7:59 ` [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements Mika Westerberg
2018-07-31 15:13 ` Gustavo A. R. Silva [this message]
2018-07-31 18:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e51d4b-db10-a402-8f08-40f98a86f7ba@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).