From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 074BECE7A95 for ; Mon, 25 Sep 2023 10:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231747AbjIYKkq (ORCPT ); Mon, 25 Sep 2023 06:40:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbjIYKkp (ORCPT ); Mon, 25 Sep 2023 06:40:45 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE7CDF for ; Mon, 25 Sep 2023 03:40:37 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99bdeae1d0aso744851366b.1 for ; Mon, 25 Sep 2023 03:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695638436; x=1696243236; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gTgYzCmClSrC0NT1OaMW2kpEZtu8VhZRt0PLLo2GDI0=; b=VwWnNloEIjVk1okdeONFgoRIRPJ0Zfdc5VeuwrqCXWSQN/HPMpFlh4PQrHhNjXKXrd w2gjGQlUjGoiAchtvanmtaghZC1AvwKHxEtc6EPuUhMQYtvXdqXGtuNKM37D0XqNKZD2 cq4ET+L4aORptDY7gaZgeTqqDdkiPaJBs54rKNVdw8Kxm2bk+bCpP+ajSBNqgUkpJ73x DfOcW4MHoTO3lx6oWPP9J4d8pvhzTJzLKziZIW6/rwx6/zmkYv7INh6+owMH50b7IlfK g7+k4VbQ0f0QZS5Zydw+G3YvsLl94G+781QNhTeTzcu1aTtttjdT4t3mDinzPu96Ab6e 2wpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695638436; x=1696243236; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gTgYzCmClSrC0NT1OaMW2kpEZtu8VhZRt0PLLo2GDI0=; b=mylRalD6kn+uNKg5XnskBv8kulmgaNvXk9/o8+CSjhgL6WSAZiXo9CcuFlTGij0Tq2 j5w2iKq8p2Ym8wris228hJav0Pn5LbjuVAm5gLpWMNGYBwrtDmI/MrvSWY08cpJ3Ox5x jdzaKWMPLJ3PQAPbMwXC4HENguRzpTZWUwzV+QJTxOmlE9O2z/W4RQzZnGWmzn5jcE/V 0xLfYaEYbwV48oNZ+sKfkrV2ZbP+Sz7/q51Yuz3KyuERWxqmduvDJoPz9jtXrTb1ltfw XiS27oI1CbSkEnqObAlOe1tOxyAd1MUlsidoYO0q8/P208cY24B3fGu/DJmp/mQM6CzR S6fg== X-Gm-Message-State: AOJu0YznPfeQPFT6ASeiERkEiftf6mazfxo6eDGye1PXYRrJKtxUTSZz apb18N7HyiubDMLfpTFDbDqdltyun6jQFfnz88ygtw== X-Google-Smtp-Source: AGHT+IGnLOgDtjX8vwFuRmMuFEi5amDSmJMGLDt4RQdUEiWqV1JJ81Ye6UYvuHUuJ6kRe9gmIH+vEQ== X-Received: by 2002:a17:906:5350:b0:9ae:5aa5:ee6c with SMTP id j16-20020a170906535000b009ae5aa5ee6cmr4797281ejo.12.1695638436293; Mon, 25 Sep 2023 03:40:36 -0700 (PDT) Received: from [192.168.101.165] (178235177023.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.23]) by smtp.gmail.com with ESMTPSA id i4-20020a170906850400b00992a8a54f32sm6096464ejx.139.2023.09.25.03.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 03:40:36 -0700 (PDT) Message-ID: <09058de7-e207-414b-ab4c-88f0cbde9c22@linaro.org> Date: Mon, 25 Sep 2023 12:40:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Add interconnect bandwidth for PCIe Gen4 Content-Language: en-US To: Abel Vesa Cc: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com, andersson@kernel.org, bhelgaas@google.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230924160713.217086-1-manivannan.sadhasivam@linaro.org> <18635bed-b7e3-4acb-b176-cd9f87a35c7f@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 25.09.2023 12:37, Abel Vesa wrote: > On 23-09-25 12:34:53, Konrad Dybcio wrote: >> On 25.09.2023 12:33, Abel Vesa wrote: >>> On 23-09-25 10:57:47, Konrad Dybcio wrote: >>>> On 24.09.2023 18:07, Manivannan Sadhasivam wrote: >>>>> PCIe Gen4 supports the interconnect bandwidth of 1969 MBps. So let's add >>>>> the bandwidth support in the driver. Otherwise, the default bandwidth of >>>>> 985 MBps will be used. >>>>> >>>>> Signed-off-by: Manivannan Sadhasivam >>>>> --- >>>>> drivers/pci/controller/dwc/pcie-qcom.c | 7 +++++-- >>>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c >>>>> index 297442c969b6..6853123f92c1 100644 >>>>> --- a/drivers/pci/controller/dwc/pcie-qcom.c >>>>> +++ b/drivers/pci/controller/dwc/pcie-qcom.c >>>>> @@ -1384,11 +1384,14 @@ static void qcom_pcie_icc_update(struct qcom_pcie *pcie) >>>>> case 2: >>>>> bw = MBps_to_icc(500); >>>>> break; >>>>> + case 3: >>>>> + bw = MBps_to_icc(985); >>>>> + break; >>>>> default: >>>>> WARN_ON_ONCE(1); >>>>> fallthrough; >>>>> - case 3: >>>>> - bw = MBps_to_icc(985); >>>>> + case 4: >>>>> + bw = MBps_to_icc(1969); >>>>> break; >>>> Are you adding case 4 under `default`? That looks.. bizzare.. >>> >>> That's intentional. You want it to use 1969MBps if there is a different >>> gen value. AFAIU. >> Gah right, then the commit message is wrong. > > Yep, should be: "Otherwise, the default bandwidth of 1969 MBps will be > used." > > But maybe we should not default to that. Maybe we should still default > to 985 MBps. Perhaps we shouldn't have a default at all.. E.g. if the gen5 bus may get clogged if we exceed gen4 limits Konrad