From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f195.google.com ([74.125.82.195]:41742 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755456AbeEaQBs (ORCPT ); Thu, 31 May 2018 12:01:48 -0400 Subject: Re: [PATCH] PCI: Check for PCIe downtraining conditions To: Sinan Kaya , Alex_Gagniuc@Dellteam.com, bhelgaas@google.com Cc: Austin.Bolen@dell.com, Shyam.Iyer@dell.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180531150535.9684-1-mr.nuke.me@gmail.com> <28004506-24f0-6d10-2d1e-074e0483d2f9@codeaurora.org> <4e0611c872054e768daa96b302651db3@ausx13mps321.AMER.DELL.COM> <3b8a895b-3080-7ddb-cbfd-5aa972e9bf65@gmail.com> <35563ce3-e235-096c-4b9b-5f3664d67d0f@codeaurora.org> From: "Alex G." Message-ID: <093b2789-39a1-db9e-5783-b0488b3c9ccd@gmail.com> Date: Thu, 31 May 2018 11:01:45 -0500 MIME-Version: 1.0 In-Reply-To: <35563ce3-e235-096c-4b9b-5f3664d67d0f@codeaurora.org> Content-Type: text/plain; charset=utf-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/31/2018 10:54 AM, Sinan Kaya wrote: > On 5/31/2018 11:46 AM, Alex G. wrote: >>> https://lkml.org/lkml/2018/3/30/553 >> Oh, pcie_get_speed_cap()/pcie_get_width_cap() seems to handle the >> capability. Not seeing one for status and speed name. >> >>> are you working on linux-next? >> v4.17-rc7 >> > > I think everything you need is in the series. I don't know which linux > tree this landed or if it landed. Probably, it is shipping for 4.18. > Need some help from Bjorn where to locate these. > > Fri, 30 Mar 2018 16:04:40 -0500 > > Bjorn Helgaas (6): > bnx2x: Report PCIe link properties with pcie_print_link_status() > bnxt_en: Report PCIe link properties with pcie_print_link_status() > cxgb4: Report PCIe link properties with pcie_print_link_status() > fm10k: Report PCIe link properties with pcie_print_link_status() > ixgbe: Report PCIe link properties with pcie_print_link_status() > PCI: Remove unused pcie_get_minimum_link() I remember seeing some of these in my tree. > Tal Gilboa (8): > PCI: Add pcie_get_speed_cap() to find max supported link speed > PCI: Add pcie_get_width_cap() to find max supported link width > PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth > PCI: Add pcie_bandwidth_available() to compute bandwidth available to device I definitely have these. > PCI: Add pcie_print_link_status() to log link speed and whether it's limited This one, I have, but it's not what I need. This looks at the available bandwidth from root port to endpoint, whereas I'm only interested in downtraining between endpoint and upstream port. Alex