public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: mani@kernel.org, kwilczynski@kernel.org, kishon@kernel.org,
	bhelgaas@google.com, cassel@kernel.org, Frank.Li@nxp.com,
	dlemoal@kernel.org, christian.bruel@foss.st.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: pci-epf-test: Fix sleeping function being called from atomic context
Date: Tue, 14 Oct 2025 08:16:10 +0530	[thread overview]
Message-ID: <097fcbe3-2433-4010-a247-6e1960ca15ac@gmail.com> (raw)
In-Reply-To: <20251013214033.GA865945@bhelgaas>

On 14/10/25 03:10, Bjorn Helgaas wrote:
> Thanks for the fix!  It looks like you posted it during the v6.18
> merge window, so it was a little bit too late to be included in the
> v6.18 changes, but it looks like good v6.19 material.
> 
> Can you please:
> 
>   - Rebase to pci/main (v6.18-rc1)
>   - Add a space before each "("
>   - Remove the timestamps because they're unnecessary distraction
>   - Add "()" after function names in commit log
>   - s/irq/IRQ/
>   - Rewrap the commit log to fit in 75 columns
>   - Rewrap the code below to fit in 78 columns because most of the
>     rest of the file does
>   - Carry Niklas' Reviewed-by when you post the v3
> 

Hi,

Thanks for the helpful review. I sent a v3 patch to address above review points.

Link to v3: https://lore.kernel.org/all/20251014024109.42287-1-bhanuseshukumar@gmail.com/

Regards,
Bhanu Seshu Kumar Valluri


      reply	other threads:[~2025-10-14  2:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30  2:38 [PATCH v2] PCI: endpoint: pci-epf-test: Fix sleeping function being called from atomic context Bhanu Seshu Kumar Valluri
2025-10-09  5:51 ` Bhanu Seshu Kumar Valluri
2025-10-09  9:37 ` Niklas Cassel
2025-10-13 21:40 ` Bjorn Helgaas
2025-10-14  2:46   ` Bhanu Seshu Kumar Valluri [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=097fcbe3-2433-4010-a247-6e1960ca15ac@gmail.com \
    --to=bhanuseshukumar@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=christian.bruel@foss.st.com \
    --cc=dlemoal@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox