linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>,
	qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: [PATCH v2 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Mon, 24 Feb 2014 09:02:21 +0100	[thread overview]
Message-ID: <09a448376c6da694f2d865a063f0eb75efa2e408.1393191330.git.agordeev@redhat.com> (raw)
In-Reply-To: <cover.1393191330.git.agordeev@redhat.com>

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Log message code 0x00c6 preserved, although it is reported
after successful call to pci_enable_msix_range(), not before
possibly unsuccessful call to pci_enable_msix(). Consumers
of the error code should not notice the difference.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: qla2xxx-upstream@qlogic.com
Cc: linux-scsi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/scsi/qla2xxx/qla_isr.c |   27 +++++++++++----------------
 1 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 9bc86b9..b2dcfa4 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2896,27 +2896,22 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp)
 	for (i = 0; i < ha->msix_count; i++)
 		entries[i].entry = i;
 
-	ret = pci_enable_msix(ha->pdev, entries, ha->msix_count);
-	if (ret) {
-		if (ret < MIN_MSIX_COUNT)
-			goto msix_failed;
-
+	ret = pci_enable_msix_range(ha->pdev,
+				    entries, MIN_MSIX_COUNT, ha->msix_count);
+	if (ret < 0) {
+		ql_log(ql_log_fatal, vha, 0x00c7,
+		    "MSI-X: Failed to enable support, "
+		    "giving   up -- %d/%d.\n",
+		    ha->msix_count, ret);
+		goto msix_out;
+	} else if (ret < ha->msix_count) {
 		ql_log(ql_log_warn, vha, 0x00c6,
 		    "MSI-X: Failed to enable support "
 		    "-- %d/%d\n Retry with %d vectors.\n",
 		    ha->msix_count, ret, ret);
-		ha->msix_count = ret;
-		ret = pci_enable_msix(ha->pdev, entries, ha->msix_count);
-		if (ret) {
-msix_failed:
-			ql_log(ql_log_fatal, vha, 0x00c7,
-			    "MSI-X: Failed to enable support, "
-			    "giving   up -- %d/%d.\n",
-			    ha->msix_count, ret);
-			goto msix_out;
-		}
-		ha->max_rsp_queues = ha->msix_count - 1;
 	}
+	ha->msix_count = ret;
+	ha->max_rsp_queues = ha->msix_count - 1;
 	ha->msix_entries = kzalloc(sizeof(struct qla_msix_entry) *
 				ha->msix_count, GFP_KERNEL);
 	if (!ha->msix_entries) {
-- 
1.7.7.6


  parent reply	other threads:[~2014-02-24  8:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  8:02 [PATCH v2 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 01/23] be2iscsi: Use pci_enable_msix_exact() " Alexander Gordeev
2014-03-11 17:06   ` Jayamohan Kallickal
2014-02-24  8:02 ` [PATCH v2 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-03-02  8:01   ` Anil Gurumurthy
2014-02-24  8:02 ` [PATCH v2 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-03-02  8:02   ` Anil Gurumurthy
2014-02-24  8:02 ` [PATCH v2 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 07/23] fnic: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 09/23] hpsa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 10/23] isci: " Alexander Gordeev
2014-03-03 13:56   ` Dorau, Lukasz
2014-02-24  8:02 ` [PATCH v2 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 14/23] megaraid: " Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 16/23] mpt3sas: " Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24  8:02 ` Alexander Gordeev [this message]
2014-02-24  8:02 ` [PATCH v2 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24  8:02 ` [PATCH v2 23/23] vmw_pvscsi: " Alexander Gordeev
2014-03-04 19:27   ` Arvind Kumar
2014-02-25  8:37 ` [PATCH v2 00/23] scsi: Use pci_enable_msix_range() " Alexander Gordeev
2014-03-13  4:04 ` Bjorn Helgaas
2014-03-13  7:04   ` James Bottomley
2014-04-02 11:49   ` Alexander Gordeev
2014-04-02 17:00     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09a448376c6da694f2d865a063f0eb75efa2e408.1393191330.git.agordeev@redhat.com \
    --to=agordeev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qla2xxx-upstream@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).