From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v4 6/6] PCI: rcar: Shut the PHY down in failpath To: Simon Horman Cc: linux-pci@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Lorenzo Pieralisi , Phil Edworthy , Wolfram Sang , linux-renesas-soc@vger.kernel.org, Bjorn Helgaas References: <20180524143624.26718-1-marek.vasut+renesas@gmail.com> <20180524143624.26718-7-marek.vasut+renesas@gmail.com> <20180528084813.ic5gyos7hq5vxknw@verge.net.au> From: Marek Vasut Message-ID: <0a7b03be-b2f8-0965-ac5c-5bb3988a6da0@gmail.com> Date: Sat, 2 Jun 2018 01:30:00 +0200 MIME-Version: 1.0 In-Reply-To: <20180528084813.ic5gyos7hq5vxknw@verge.net.au> Content-Type: text/plain; charset=utf-8 List-ID: On 05/28/2018 10:48 AM, Simon Horman wrote: > On Thu, May 24, 2018 at 04:36:24PM +0200, Marek Vasut wrote: >> If anything fails past phy_init_fn() and the system is a Gen3 with >> a PHY, the PHY will be left on and inited. This is caused by the >> phy_init_fn, which is in fact a pointer to rcar_pcie_phy_init_gen3() >> function, which starts the PHY, yet has no counterpart in the failpath. >> Add that counterpart. >> >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Lorenzo Pieralisi >> Cc: Phil Edworthy >> Cc: Simon Horman >> Cc: Wolfram Sang >> Cc: linux-renesas-soc@vger.kernel.org >> Fixes: 517ca93a7159 ("PCI: rcar: Add R-Car gen3 PHY support") > > Acked-by: Simon Horman While I see the first 5 in today's next, I don't see this one there, so it'd be nice to add it too. -- Best regards, Marek Vasut