From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Linux 5.15-rc1
Date: Mon, 13 Sep 2021 22:59:05 +0200 [thread overview]
Message-ID: <0a8e8186-741e-a92f-9507-448d574ae7ca@gmail.com> (raw)
In-Reply-To: <20210913203234.GA6762@codemonkey.org.uk>
On 13.09.2021 22:32, Dave Jones wrote:
> On Mon, Sep 13, 2021 at 10:22:57PM +0200, Heiner Kallweit wrote:
>
> > > This didn't help I'm afraid :(
> > > It changed the VPD warning, but that's about it...
> > >
> > > [ 184.235496] pci 0000:02:00.0: calling quirk_blacklist_vpd+0x0/0x22 @ 1
> > > [ 184.235499] pci 0000:02:00.0: [Firmware Bug]: disabling VPD access (can't determine size of non-standard VPD format)
> > > [ 184.235501] pci 0000:02:00.0: quirk_blacklist_vpd+0x0/0x22 took 0 usecs
> > >
> > With this patch there's no VPD access to this device any longer. So this can't be
> > the root cause. Do you have any other PCI device that has VPD capability?
> > -> Capabilities: [...] Vital Product Data
>
>
> 01:00.0 Ethernet controller: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01)
> Subsystem: Device 1dcf:030a
> ...
> Capabilities: [e0] Vital Product Data
> Unknown small resource type 06, will not decode more.
>
The stall being discussed would have been prevented by the VPD tag
verification in pci_vpd_size(). It seems that now random data is
interpreted as VPD tags what results in VPD access to an address
that makes the device stall.
I do not really follow Linus' argumentation that VPD shouldn't be
accessed during boot because other slow "VPD-like" devices are
accessed too, e.g. DDR SPD via I2C.
>
> I'll add that to the quirk list and see if that helps.
>
> Dave
>
next prev parent reply other threads:[~2021-09-13 20:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHk-=wgbygOb3hRV+7YOpVcMPTP2oQ=iw6tf09Ydspg7o7BsWQ@mail.gmail.com>
[not found] ` <20210913141818.GA27911@codemonkey.org.uk>
2021-09-13 18:59 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 19:51 ` Linus Torvalds
2021-09-13 20:09 ` Bjorn Helgaas
2021-09-13 20:11 ` Heiner Kallweit
2021-09-13 20:15 ` Linus Torvalds
2021-09-13 20:15 ` Dave Jones
2021-09-13 20:22 ` Heiner Kallweit
2021-09-13 20:32 ` Dave Jones
2021-09-13 20:44 ` Linux 5.15-rc1 - 82599ES VPD access isue Heiner Kallweit
2021-09-13 23:32 ` [Intel-wired-lan] " Hisashi T Fujinaka
2021-09-14 5:51 ` Heiner Kallweit
2021-09-14 14:24 ` Dave Jones
2021-09-14 18:28 ` Fujinaka, Todd
2021-09-14 20:00 ` Hisashi T Fujinaka
2021-09-14 21:51 ` Heiner Kallweit
2021-09-15 14:18 ` Hisashi T Fujinaka
2021-09-15 16:05 ` Heiner Kallweit
2021-09-15 16:16 ` Hisashi T Fujinaka
2021-09-15 22:32 ` Bjorn Helgaas
2021-09-15 23:46 ` Hisashi T Fujinaka
2021-09-17 15:09 ` Bjorn Helgaas
2021-09-13 20:59 ` Heiner Kallweit [this message]
2021-09-13 23:35 ` Linux 5.15-rc1 Bjorn Helgaas
2021-09-13 20:32 ` Heiner Kallweit
2021-09-13 20:36 ` Linus Torvalds
2021-09-13 20:41 ` Dave Jones
2021-09-13 23:46 ` Bjorn Helgaas
2021-09-14 0:39 ` Dave Jones
2021-09-14 6:21 ` Heiner Kallweit
2021-09-14 11:26 ` Bjorn Helgaas
2021-09-14 17:07 ` Heiner Kallweit
2021-09-14 21:55 ` Bjorn Helgaas
2021-09-14 22:06 ` Heiner Kallweit
2021-09-14 22:33 ` Dave Jones
2021-09-15 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a8e8186-741e-a92f-9507-448d574ae7ca@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).