Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

Mario Limonciello
2024-01-18T15:47:12Z

On 1/18/2024 00:00, Mika Westerberg wrote:
>> Before my patch, you see that the JHL6540 controller is inaccurately
>> labeled “removable”:
>> $ udevadm info -a -p /sys/bus/pci/devices/0000:05:00.0 | grep -e
>> {removable} -e {device} -e {vendor} -e looking
>> looking at device '/devices/pci0000:00/0000:00:1d.4/0000:05:00.0':
>> ATTR{device}=="0x15d3"
>> ATTR{removable}=="removable"
>> ATTR{vendor}=="0x8086"
>
> This is actually accurate. The Thunderbolt controller is itself
> hot-removable and that BTW happens to be hot-removed when fwupd applies
> firmware upgrades to the device.

Depending on the consumers of this removable attribute I wonder if we
need to a new ATTR of "external" instead of overloading "removable".