From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.187]:65345 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164AbaESQ7k (ORCPT ); Mon, 19 May 2014 12:59:40 -0400 From: Arnd Bergmann To: Will Deacon Cc: Srikanth Thokala , "bhelgaas@google.com" , "michals@xilinx.com" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH] PCI: Generic Configuration Access Mechanism support Date: Mon, 19 May 2014 18:59:36 +0200 Message-ID: <10203370.xOnWqK3Vx4@wuerfel> In-Reply-To: <20140519163223.GP15130@arm.com> References: <1400422125-2209-1-git-send-email-sthokal@xilinx.com> <20140519163223.GP15130@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Monday 19 May 2014 17:32:23 Will Deacon wrote: > On Sun, May 18, 2014 at 03:08:45PM +0100, Srikanth Thokala wrote: > > This patch adds support for a generic CAM and ECAM configuration > > space accesses. > > Looks good to me, thanks Srikanth! > > Arnd: is this the sort of thing you were expecting? The > ->is_valid_cfg_access callback is a bit horrible, but I can't think of > anything better. > > I can include this in the next posting of my PCI patches. Yes, this is roughly what I had in mind, thanks a lot! I'll comment a bit more on the patch itself Arnd