From: Waiman Long <llong@redhat.com>
To: Guangbo Cui <jckeep.cuiguangbo@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/2] PCI/aer_inject: Adjust locking for PREEMPT_RT
Date: Sun, 26 Oct 2025 19:16:36 -0400 [thread overview]
Message-ID: <10579b1f-1005-4842-934f-0b9c6b65971d@redhat.com> (raw)
In-Reply-To: <20251026044335.19049-2-jckeep.cuiguangbo@gmail.com>
On 10/26/25 12:43 AM, Guangbo Cui wrote:
> This patch series addresses locking issues in the AER injection
> path under PREEMPT_RT.
>
> Signed-off-by: Guangbo Cui <jckeep.cuiguangbo@gmail.com>
> ---
> Changes in v3:
> - Remove unnecessary lock in aer_inject_exit.
> - Link to v2: https://lore.kernel.org/all/20251009150651.93618-1-jckeep.cuiguangbo@gmail.com/
>
> ---
> Guangbo Cui (2):
> PCI/aer_inject: Convert inject_lock to raw_spinlock_t
> PCI/aer_inject: Remove unnecessary lock in aer_inject_exit
You should reverse the patch ordering. Patch 2 should come first before
the patch 1. Otherwise, applying just patch 1 without patch 2 will fail
compilation.
Cheers,
Longman
>
> drivers/pci/pcie/aer_inject.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2025-10-26 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 4:43 [PATCH v3 0/2] PCI/aer_inject: Adjust locking for PREEMPT_RT Guangbo Cui
2025-10-26 4:43 ` [PATCH v3 1/2] PCI/aer_inject: Convert inject_lock to raw_spinlock_t Guangbo Cui
2025-10-27 8:11 ` Sebastian Andrzej Siewior
2025-10-27 15:11 ` Guangbo Cui
2025-10-26 4:43 ` [PATCH v3 2/2] PCI/aer_inject: Remove unnecessary lock in aer_inject_exit Guangbo Cui
2025-10-27 8:12 ` Sebastian Andrzej Siewior
2025-10-26 23:16 ` Waiman Long [this message]
2025-10-27 15:10 ` [PATCH v3 0/2] PCI/aer_inject: Adjust locking for PREEMPT_RT Guangbo Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10579b1f-1005-4842-934f-0b9c6b65971d@redhat.com \
--to=llong@redhat.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=clrkwllms@kernel.org \
--cc=jckeep.cuiguangbo@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).