From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150EAC43613 for ; Mon, 24 Jun 2019 10:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D92B020674 for ; Mon, 24 Jun 2019 10:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfFXK16 (ORCPT ); Mon, 24 Jun 2019 06:27:58 -0400 Received: from gate.crashing.org ([63.228.1.57]:43624 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727101AbfFXK16 (ORCPT ); Mon, 24 Jun 2019 06:27:58 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5OARqGN028142; Mon, 24 Jun 2019 05:27:53 -0500 Message-ID: <10cafe60fa12d3801d8645046be02771e8af7619.camel@kernel.crashing.org> Subject: Re: Question about call to pci_assign_unassigned_bus_resources in amdgpu From: Benjamin Herrenschmidt To: "Koenig, Christian" Cc: "Deucher, Alexander" , "linux-pci@vger.kernel.org" Date: Mon, 24 Jun 2019 20:27:49 +1000 In-Reply-To: <0680ee65-5960-18b8-d7a2-eb87ec2056ef@amd.com> References: <71904c98-be86-2807-d5c9-4b90c7387f6f@amd.com> <0680ee65-5960-18b8-d7a2-eb87ec2056ef@amd.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 2019-06-24 at 09:42 +0000, Koenig, Christian wrote: > > > Ok, Ill plumb it that way in my branch, I'll let you know when it's > > worth testing. BTW. Which GPUs typically are affected ? I'm pretty > > sure > > my old R9 290 isn't :-) But I was thinking of upgrading so... > > Well in theory we have the functionality 10+ years now, but only > activated it in all hardware versions recently. > > Polaris and Vega should definitely have it, older hardware most > likely not. > > You can check the PCI capabilities and look for #15, if it's present > then that should be supported. Ok, well, we'll see if I decide to get myself a Navi when it comes out, otherwise I'll rely on your testing :) That said, I'm keen on having a discussion about our resource assignment code at Plumbers with whoever can make it. The current situation is rather horrible, it would be good to ensure at least that we all understand and agree on what it's trying to do, what it's actually doing, and what we want to do, which the more I stare at it I'm reasonably sure are very different things depending on the context... Cheers, Ben.