public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Phillip Susi <psusi@ubuntu.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: enabling aspm on ati radeon
Date: Mon, 20 May 2013 22:01:40 +0200	[thread overview]
Message-ID: <11045555.dLhhFPGoSV@vostro.rjw.lan> (raw)
In-Reply-To: <CAErSpo6MGwHLJvis+4=vdQEJN=Qb9aC5e9=3Q6MdTB-HH84YBw@mail.gmail.com>

On Monday, May 20, 2013 07:34:44 AM Bjorn Helgaas wrote:
> On Fri, May 17, 2013 at 7:20 PM, Phillip Susi <psusi@ubuntu.com> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 05/17/2013 08:40 PM, Bjorn Helgaas wrote:
> >> Right; I meant RO per the PCIe spec.  If it's RW on your chip,
> >> setpci should be able to write it.
> >
> > I assume it would do no good to change it at this point; it would need
> > to already be set at the time the kernel reads it and decides whether
> > or not to enable it, so I'd have to have grub set it before loading
> > the kernel.
> 
> Yeah, setting the capability bits after the kernel has booted wouldn't
> change anything except what lspci reports.
> 
> >> If you can measure the power consumption, you might be able to see
> >> a difference there.  I've seen people report that, but don't know
> >> how they do it.  For example:
> >> https://lkml.kernel.org/r/CANUX_P3F5YhbZX3WGU-j1AGpbXb_T9Bis2ErhvKkFMtDvzatVQ@mail.gmail.com
> >
> > After
> >>
> > enabling it on both ends ( despite the root port still claiming
> > it is not supported ) I still see ~121 watts according to the
> > Kill-A-Watt my system is plugged into.  Oh well.
> 
> ASPM only saves power when the PCIe link is idle.  I'm not a video
> person, so I don't know how video usage translates into link usage,
> and I don't know how much power it saves.  My guess is that the amount
> is fairly small and might not be measurable with a Kill-A-Watt.

I'm pretty sure it's measurable, at least in some cases.  Phoronix did quite
some fuss about a commit that caused ASPM to not work any more on some systems
some time ago, so he had to be able to measure it (and it was called a "major
power regression").

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2013-05-20 19:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <519443A1.8050905@ubuntu.com>
2013-05-16  8:58 ` enabling aspm on ati radeon Rafael J. Wysocki
2013-05-16 16:42   ` Bjorn Helgaas
     [not found]     ` <5195596C.3000406@ubuntu.com>
2013-05-17 17:31       ` Bjorn Helgaas
2013-05-17 18:04         ` Phillip Susi
2013-05-17 19:52           ` Bjorn Helgaas
2013-05-17 20:10             ` Phillip Susi
2013-05-17 20:24               ` Bjorn Helgaas
2013-05-17 21:12                 ` Phillip Susi
2013-05-17 21:28                   ` Bjorn Helgaas
2013-05-17 23:36                     ` Phillip Susi
2013-05-17 23:52                       ` Bjorn Helgaas
2013-05-18  0:15                         ` Phillip Susi
2013-05-18  0:40                           ` Bjorn Helgaas
2013-05-18  1:20                             ` Phillip Susi
2013-05-20 13:34                               ` Bjorn Helgaas
2013-05-20 20:01                                 ` Rafael J. Wysocki [this message]
2013-05-21 13:31                                   ` Phillip Susi
2013-05-21 18:50                                     ` Sebastian
2013-05-24 19:57                                   ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11045555.dLhhFPGoSV@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox