Re: [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller

[<Daire.McNamara@microchip.com>]

On 11/02/2021 13:07, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi Ben,
> 
> On Thu, Feb 11, 2021 at 2:03 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> On 10/02/2021 13:07, Geert Uytterhoeven wrote:
>>> On Mon, Jan 25, 2021 at 5:33 PM <daire.mcnamara@microchip.com> wrote:
>>>> From: Daire McNamara <daire.mcnamara@microchip.com>
>>>>
>>>> Add support for the Microchip PolarFire PCIe controller when
>>>> configured in host (Root Complex) mode.
>>>>
>>>> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>
>>> Thanks for your patch!
>>>
>>>> --- a/drivers/pci/controller/Kconfig
>>>> +++ b/drivers/pci/controller/Kconfig
>>>> @@ -298,6 +298,16 @@ config PCI_LOONGSON
>>>>            Say Y here if you want to enable PCI controller support on
>>>>            Loongson systems.
>>>>
>>>> +config PCIE_MICROCHIP_HOST
>>>> +       bool "Microchip AXI PCIe host bridge support"
>>>> +       depends on PCI_MSI && OF
>>>> +       select PCI_MSI_IRQ_DOMAIN
>>>> +       select GENERIC_MSI_IRQ_DOMAIN
>>>> +       select PCI_HOST_COMMON
>>>> +       help
>>>> +         Say Y here if you want kernel to support the Microchip AXI PCIe
>>>> +         Host Bridge driver.
>>>
>>> Is this PCIe host bridge accessible only from the PolarFire RISC-V
>>> CPU cores, or also from softcores implemented in the PolarFire FPGA?
>>>
>>> In case of the former, we want to add a
>>>
>>>      depends on CONFIG_SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
>>
>>
>> I'd say having it on COMPILE_TEST if there's no polarfire includes
>> would be useful to allow compile testing of the driver by the build
>> robots.
> 
> As currently there is no platform dependency at all, it will be
> compile-tested by allmodconfig on every config that has PCI_MSI && OF.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
This PCIe host bridge is accessible from softcores implemented in the PolarFire SoC FPGA.  But, I still thing its reasonable to add a 'depends on CONFIG_SOC_MICROCHIP_POLARFIRE || COMPILE_TEST' line.
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>