From: Arnd Bergmann <arnd@arndb.de>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH] link up validation moved to pcie-designware
Date: Mon, 08 Feb 2016 17:40:30 +0100 [thread overview]
Message-ID: <13142496.gh5Gdib4M6@wuerfel> (raw)
In-Reply-To: <b00bf38b4351831b97892b747d48c9206fbab9c7.1454935205.git.jpinto@synopsys.com>
On Monday 08 February 2016 12:43:58 Joao Pinto wrote:
> This patch goal is to centralize in pcie-designware the link up
> validation. A new function was added to pci-designware that is
> responsible for doing such a task. This was implemented in a form that
> permits flexibility for all SoCs.
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
I believe the different timeouts in each driver are just coincidence
and partly based on who reviewed which driver.
I'm pretty sure it doesn't really matter at all, and we can just use
the same loop for every one.
I was also hoping that a little more than just the loop could be
unified between the various establish_link() functions. I have a
feeling that each one just implements a subset of what is actually
required, so they are buggy in different ways because nobody
has the datasheet.
Arnd
next prev parent reply other threads:[~2016-02-08 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 12:43 [PATCH] link up validation moved to pcie-designware Joao Pinto
2016-02-08 13:03 ` Gabriele Paoloni
2016-02-08 15:12 ` Joao Pinto
2016-02-08 15:29 ` Gabriele Paoloni
2016-02-08 15:30 ` Joao Pinto
2016-02-25 16:28 ` Bjorn Helgaas
2016-02-08 16:40 ` Arnd Bergmann [this message]
2016-02-08 16:41 ` Bjorn Helgaas
2016-02-08 16:43 ` Joao Pinto
2016-02-08 16:46 ` Arnd Bergmann
2016-02-08 16:48 ` Joao Pinto
2016-02-09 15:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13142496.gh5Gdib4M6@wuerfel \
--to=arnd@arndb.de \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).