linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: linux-pci@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
	mstowe@redhat.com, ddutile@redhat.com, jparadis@redhat.com,
	matthew.wilcox@linux.intel.com, jbarnes@virtuousgeek.org
Subject: [PATCH] pci: Workaround Stratus broken PCIE hierarchy
Date: Thu, 10 Nov 2011 09:00:13 -0500	[thread overview]
Message-ID: <1320933613-25909-1-git-send-email-prarit@redhat.com> (raw)

Stratus systems have a hierarchy that includes a PCIE Downstream bridge
connected to a PCIE Upstream bridge and a PCI Downstream bridge.  The system
boots with this wrong hierarchy into a crippled mode (USB doesn't work,
network doesn't work ...).  Avoiding the Downstream bridge check in
only_one_child() causes all the bridges to be enumerated and the system
to function properly.

Unfortunately this hardware is currently available so we should at least
keep it functional.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

Cc: mstowe@redhat.com
Cc: ddutile@redhat.com
Cc: jparadis@redhat.com
Cc: matthew.wilcox@linux.intel.com
Cc: jbarnes@virtuousgeek.org
---
 drivers/pci/probe.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 04e74f4..bc76812 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/cpumask.h>
 #include <linux/pci-aspm.h>
+#include <linux/dmi.h>
 #include "pci.h"
 
 #define CARDBUS_LATENCY_TIMER	176	/* secondary latency timer */
@@ -1275,7 +1276,15 @@ static int only_one_child(struct pci_bus *bus)
 	struct pci_dev *parent = bus->self;
 	if (!parent || !pci_is_pcie(parent))
 		return 0;
-	if (parent->pcie_type == PCI_EXP_TYPE_ROOT_PORT ||
+	if (parent->pcie_type == PCI_EXP_TYPE_ROOT_PORT)
+		return 1;
+	/*
+	 * Stratus/NEC ftServer systems have a broken PCIE hierarchy in which
+	 * one upstream and one downstream port are plugged into a downstream
+	 * port.  Avoiding the downstream port check here results in a
+	 * functional system.
+	 */
+	if (!dmi_name_in_vendors("ftServer") &&
 	    parent->pcie_type == PCI_EXP_TYPE_DOWNSTREAM)
 		return 1;
 	return 0;
-- 
1.7.1


             reply	other threads:[~2011-11-10 14:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 14:00 Prarit Bhargava [this message]
2011-11-10 14:31 ` [PATCH] pci: Workaround Stratus broken PCIE hierarchy Matthew Wilcox
2011-11-10 16:50   ` Don Dutile
2011-11-11 17:41     ` James Paradis
2011-11-11 19:13       ` Don Dutile
2011-11-11 20:29         ` Bjorn Helgaas
2011-11-11 20:35           ` Don Dutile
2011-11-14 14:44             ` Prarit Bhargava
2011-11-14 18:14               ` Matthew Wilcox
2011-11-14 19:50                 ` Prarit Bhargava
2011-11-15 20:16                   ` Matthew Wilcox
2011-11-15 15:56                 ` Prarit Bhargava
2011-11-15 16:08                   ` Rolf Eike Beer
2011-11-15 18:14                     ` Bjorn Helgaas
2011-11-15 18:25                       ` Prarit Bhargava
2011-11-15 21:08                         ` James Paradis
2011-11-15 21:52                           ` Myron Stowe
2011-11-15 22:14                             ` James Paradis
2011-11-15 20:15                   ` Matthew Wilcox
2011-11-16 16:53                     ` Prarit Bhargava
2011-11-17  0:18                       ` Prarit Bhargava
2011-11-15 21:53                   ` James Paradis
2011-11-15 22:27           ` James Paradis
2011-11-15 23:07             ` Don Dutile
  -- strict thread matches above, loose matches on Subject: below --
2012-04-25 17:56 Prarit Bhargava
2012-04-25 23:35 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320933613-25909-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jparadis@redhat.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.wilcox@linux.intel.com \
    --cc=mstowe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).