From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Myron Stowe <myron.stowe@redhat.com>,
linux-pci@vger.kernel.org, linux@arm.linux.org.uk,
vapier@gentoo.org, dhowells@redhat.com,
ysato@users.sourceforge.jp, tony.luck@intel.com,
fenghua.yu@intel.com, monstr@monstr.eu, ralf@linux-mips.org,
paulus@samba.org, lethal@linux-sh.org, davem@davemloft.net,
cmetcalf@tilera.com, gxt@mprc.pku.edu.cn, tglx@linutronix.de,
mingo@redhat.com, chris@zankel.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup
Date: Wed, 16 Nov 2011 09:43:50 +1100 [thread overview]
Message-ID: <1321397030.3170.15.camel@pasglop> (raw)
In-Reply-To: <20111111095930.22abd773@jbarnes-desktop>
On Fri, 2011-11-11 at 09:59 -0800, Jesse Barnes wrote:
> On Fri, 28 Oct 2011 15:47:26 -0600
> Myron Stowe <myron.stowe@redhat.com> wrote:
>
> > The 'latency timer' of PCI devices, both Type 0 and Type 1,
> > is setup in architecture-specific code [see: pcibios_set_master()].
> > There are two approaches being taken by all the architectures - check
> > if the 'latency timer' is currently set between 16 and 255 and if not
> > bring it within bounds, or, do nothing (and then there is the
> > gratuitously different parisc implementation).
> >
> > There is nothing architecture-specific about PCI's 'latency timer' so
> > this patch pulls the setup functionality up into the PCI core by
> > creating a generic 'pcibios_set_master()' function using the '__weak'
> > attribute which can be used by all architectures as a default which,
> > if necessary, can then be over-ridden by architecture-specific code.
>
> I have acks from Chris, Ralf, and Mike. Any other arch maintainers
> want to ack or nack this before it goes into my -next branch?
I somewhat missed the original patch. As long as it's a nop for ppc, I
don't care tho :-)
Cheers,
Ben.
next prev parent reply other threads:[~2011-11-15 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111028214726.20088.30551.stgit@amt.stowe>
2011-11-11 17:59 ` [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup Jesse Barnes
2011-11-15 22:43 ` Benjamin Herrenschmidt [this message]
[not found] ` <20111028214735.20088.19168.stgit@amt.stowe>
2011-12-05 19:06 ` [PATCH -v2 01/16] PCI: add declaration for pcibios_set_master() to pci core Jesse Barnes
2011-12-05 20:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321397030.3170.15.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jbarnes@virtuousgeek.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=myron.stowe@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).