* [PATCH 06/16] cpcihp: fix debug module parameter to be bool
[not found] <1327960820-11867-1-git-send-email-danny.kukawka@bisect.de>
@ 2012-01-30 22:00 ` Danny Kukawka
2012-02-03 0:06 ` Scott Murray
2012-02-10 19:40 ` Jesse Barnes
0 siblings, 2 replies; 3+ messages in thread
From: Danny Kukawka @ 2012-01-30 22:00 UTC (permalink / raw)
To: Scott Murray; +Cc: Jesse Barnes, linux-pci, linux-kernel
Fix debug variable from module parameter to be really bool to
fix 'warning: return from incompatible pointer type'.
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
drivers/pci/hotplug/cpcihp_generic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/hotplug/cpcihp_generic.c b/drivers/pci/hotplug/cpcihp_generic.c
index fb3f846..81af764 100644
--- a/drivers/pci/hotplug/cpcihp_generic.c
+++ b/drivers/pci/hotplug/cpcihp_generic.c
@@ -62,7 +62,7 @@
#define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)
/* local variables */
-static int debug;
+static bool debug;
static char *bridge;
static u8 bridge_busnr;
static u8 bridge_slot;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 06/16] cpcihp: fix debug module parameter to be bool
2012-01-30 22:00 ` [PATCH 06/16] cpcihp: fix debug module parameter to be bool Danny Kukawka
@ 2012-02-03 0:06 ` Scott Murray
2012-02-10 19:40 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Scott Murray @ 2012-02-03 0:06 UTC (permalink / raw)
To: Danny Kukawka; +Cc: Jesse Barnes, linux-pci, linux-kernel
Sorry for the delay, this looks fine.
Acked-by: Scott Murray <scott@spiteful.org>
On Mon, Jan 30, 2012 at 5:00 PM, Danny Kukawka <danny.kukawka@bisect.de> wrote:
>
> Fix debug variable from module parameter to be really bool to
> fix 'warning: return from incompatible pointer type'.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
> ---
> drivers/pci/hotplug/cpcihp_generic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpcihp_generic.c b/drivers/pci/hotplug/cpcihp_generic.c
> index fb3f846..81af764 100644
> --- a/drivers/pci/hotplug/cpcihp_generic.c
> +++ b/drivers/pci/hotplug/cpcihp_generic.c
> @@ -62,7 +62,7 @@
> #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)
>
> /* local variables */
> -static int debug;
> +static bool debug;
> static char *bridge;
> static u8 bridge_busnr;
> static u8 bridge_slot;
> --
> 1.7.7.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 06/16] cpcihp: fix debug module parameter to be bool
2012-01-30 22:00 ` [PATCH 06/16] cpcihp: fix debug module parameter to be bool Danny Kukawka
2012-02-03 0:06 ` Scott Murray
@ 2012-02-10 19:40 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2012-02-10 19:40 UTC (permalink / raw)
To: Danny Kukawka; +Cc: Scott Murray, linux-pci, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Mon, 30 Jan 2012 23:00:10 +0100
Danny Kukawka <danny.kukawka@bisect.de> wrote:
> Fix debug variable from module parameter to be really bool to
> fix 'warning: return from incompatible pointer type'.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
> ---
> drivers/pci/hotplug/cpcihp_generic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpcihp_generic.c b/drivers/pci/hotplug/cpcihp_generic.c
> index fb3f846..81af764 100644
> --- a/drivers/pci/hotplug/cpcihp_generic.c
> +++ b/drivers/pci/hotplug/cpcihp_generic.c
> @@ -62,7 +62,7 @@
> #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)
>
> /* local variables */
> -static int debug;
> +static bool debug;
> static char *bridge;
> static u8 bridge_busnr;
> static u8 bridge_slot;
Applied to my -next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-10 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1327960820-11867-1-git-send-email-danny.kukawka@bisect.de>
2012-01-30 22:00 ` [PATCH 06/16] cpcihp: fix debug module parameter to be bool Danny Kukawka
2012-02-03 0:06 ` Scott Murray
2012-02-10 19:40 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).