From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 4/4] PCI: quirk print dev name with duration
Date: Thu, 16 Feb 2012 09:54:36 -0800 [thread overview]
Message-ID: <1329414876.11146.2.camel@joe2Laptop> (raw)
In-Reply-To: <CAErSpo57hL9dFyFDvdEQcLKCPOeCh3MY3UCURvrXKPpA8W3y3A@mail.gmail.com>
On Thu, 2012-02-16 at 09:49 -0800, Bjorn Helgaas wrote:
> If you do change, remember that dev_dbg() is different from
> printk(KERN_DEBUG) in that printk(KERN_DEBUG) is always compiled-in
> and always goes to the dmesg, but dev_dbg() is only compiled in when
> DEBUG is defined, so dev_printk(KERN_DEBUG) would be a more direct
> replacement for printk(KERN_DEBUG).
Correct.
Which is why I usually add #define DEBUG or an
equivalent CONFIG option before those are converted.
Doing so allows control via dynamic debug.
next prev parent reply other threads:[~2012-02-16 17:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 5:14 [PATCH 1/4] PCI: quirk related clean up Yinghai Lu
2012-02-16 5:14 ` [PATCH 1/4] PCI: Add class support in quirk handling Yinghai Lu
2012-02-16 5:14 ` [PATCH 2/4] PCI: Specify class for quirk entry with PCI_ANY_ID Yinghai Lu
2012-02-16 5:14 ` [PATCH 3/4] PCI: Move out pci reassigndev resource alignment out of quirk Yinghai Lu
2012-02-16 5:14 ` [PATCH 4/4] PCI: quirk print dev name with duration Yinghai Lu
2012-02-16 5:25 ` Joe Perches
2012-02-16 5:35 ` Yinghai Lu
2012-02-16 5:43 ` Joe Perches
2012-02-16 7:07 ` Joe Perches
2012-02-16 17:49 ` Bjorn Helgaas
2012-02-16 17:54 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-16 5:40 [PATCH 0/4] PCI: quirk related clean up Yinghai Lu
2012-02-16 5:40 ` [PATCH 4/4] PCI: quirk print dev name with duration Yinghai Lu
2012-02-24 22:39 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329414876.11146.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=arjan@infradead.org \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).