From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH 09/13] x86, irq: Add mp_unregister_ioapic could handle hotremove ioapic
Date: Thu, 23 Feb 2012 19:48:55 -0800 [thread overview]
Message-ID: <1330055339-11662-10-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1330055339-11662-1-git-send-email-yinghai@kernel.org>
it will free ioapic related irq_desc and also clear allocated_irqs bits.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/include/asm/mpspec.h | 1 +
arch/x86/kernel/apic/io_apic.c | 42 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/mpspec.h b/arch/x86/include/asm/mpspec.h
index aca26fa..6f80e04 100644
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -97,6 +97,7 @@ static inline void early_reserve_e820_mpc_new(void) { }
void __cpuinit generic_processor_info(int apicid, int version);
#ifdef CONFIG_ACPI
int __mp_register_ioapic(int id, u32 address, u32 gsi_base, bool hot);
+int mp_unregister_ioapic(u32 gsi_base);
extern void mp_register_ioapic(int id, u32 address, u32 gsi_base);
extern void mp_override_legacy_irq(u8 bus_irq, u8 polarity, u8 trigger,
u32 gsi);
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 2e8497c..4517713 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -255,6 +255,14 @@ static void free_irq_at(unsigned int at, struct irq_cfg *cfg)
irq_free_desc(at);
}
+static void free_irqs(unsigned int from, int cnt)
+{
+ int i;
+
+ for (i = from; i < from + cnt; i++)
+ free_irq_at(i, irq_get_chip_data(i));
+}
+
static struct irq_cfg *realloc_irq_and_cfg_at(unsigned int at, int node)
{
struct irq_desc *desc = irq_to_desc(at);
@@ -328,6 +336,16 @@ static void __init reserve_ioapic_gsi_irq_extra(void)
}
}
+static void free_ioapic_gsi_irq_base(int idx)
+{
+ struct mp_ioapic_gsi *gsi_cfg = mp_ioapic_gsi_routing(idx);
+ int irq_base = gsi_cfg->irq_base;
+ int irq_cnt = gsi_cfg->gsi_end - gsi_cfg->gsi_base + 1;
+
+ if (irq_base > 0)
+ free_irqs(irq_base, irq_cnt);
+}
+
static void alloc_ioapic_saved_registers(int idx)
{
if (ioapics[idx].saved_registers)
@@ -341,6 +359,11 @@ static void alloc_ioapic_saved_registers(int idx)
pr_err("IOAPIC %d: suspend/resume impossible!\n", idx);
}
+static void free_ioapic_saved_registers(int idx)
+{
+ kfree(ioapics[idx].saved_registers);
+}
+
int __init arch_early_irq_init(void)
{
int node = cpu_to_node(0);
@@ -4166,6 +4189,25 @@ void mp_register_ioapic(int id, u32 address, u32 gsi_base)
__mp_register_ioapic(id, address, gsi_base, false);
}
+int mp_unregister_ioapic(u32 gsi_base)
+{
+ int idx;
+
+ idx = mp_find_ioapic(gsi_base);
+ if (idx < 0)
+ return -EINVAL;
+
+ free_ioapic_saved_registers(idx);
+
+ free_ioapic_gsi_irq_base(idx);
+
+ clear_fixmap(FIX_IO_APIC_BASE_0 + idx);
+ memset(&ioapics[idx], 0, sizeof(struct ioapic));
+ ioapics[idx].mp_config.apicid = 0xff;
+
+ return 0;
+}
+
/* Enable IOAPIC early just for system timer */
void __init pre_init_apic_IRQ0(void)
{
--
1.7.7
next prev parent reply other threads:[~2012-02-24 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 3:48 [PATCH 00/13] x86, irq: support ioapic device hotplug for x86 Yinghai Lu
2012-02-24 3:48 ` [PATCH 01/13] x86, irq: Convert irq_2_pin list to generic list Yinghai Lu
2012-02-24 3:48 ` [PATCH 02/13] genirq: Split __irq_reserve_irqs from irq_alloc_descs Yinghai Lu
2012-02-24 3:48 ` [PATCH 03/13] x86, irq: Add realloc_irq_and_cfg_at() Yinghai Lu
2012-02-24 3:48 ` [PATCH 04/13] x86, irq: pre-reserve irq range that are used by ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 05/13] x86, irq: add ioapic_gsi_to_irq Yinghai Lu
2012-02-24 3:48 ` [PATCH 06/13] genirq: bail out early in free_desc() Yinghai Lu
2012-02-24 3:48 ` [PATCH 07/13] x86, irq: more strict check for register ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 08/13] x86, irq: Make mp_register_ioapic could handle hotadd ioapic Yinghai Lu
2012-02-24 3:48 ` Yinghai Lu [this message]
2012-02-24 3:48 ` [PATCH 10/13] x86, irq: Make ioapics loop code skip blank slot Yinghai Lu
2012-02-24 3:48 ` [PATCH 11/13] x86, acpi, irq: Enable pci device type ioapic hotplug Yinghai Lu
2012-02-24 3:48 ` [PATCH 12/13] PCI: Make sure hotplug ioapic driver get loaded early Yinghai Lu
2012-02-24 3:48 ` [PATCH 13/13] PCI: Disable mem in the ioapic removing path Yinghai Lu
2012-02-24 16:51 ` [PATCH 00/13] x86, irq: support ioapic device hotplug for x86 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330055339-11662-10-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).