From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH 03/13] x86, irq: Add realloc_irq_and_cfg_at()
Date: Thu, 23 Feb 2012 19:48:49 -0800 [thread overview]
Message-ID: <1330055339-11662-4-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1330055339-11662-1-git-send-email-yinghai@kernel.org>
Will use it to allocate irq that are pre-reserved.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/kernel/apic/io_apic.c | 33 ++++++++++++++++++++++++++++++++-
include/linux/irq.h | 5 +++++
kernel/irq/irqdesc.c | 26 ++++++++++++++++++++++++++
3 files changed, 63 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 4c008ac..4d62f0f 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -300,6 +300,37 @@ static void free_irq_at(unsigned int at, struct irq_cfg *cfg)
irq_free_desc(at);
}
+static struct irq_cfg *realloc_irq_and_cfg_at(unsigned int at, int node)
+{
+ struct irq_desc *desc = irq_to_desc(at);
+ struct irq_cfg *cfg;
+ int res;
+
+ if (desc) {
+ if (irq_desc_get_irq_data(desc)->node == node)
+ return alloc_irq_and_cfg_at(at, node);
+
+ cfg = irq_desc_get_chip_data(desc);
+ if (cfg) {
+ /* shared irq */
+ if (!list_empty(&cfg->irq_2_pin))
+ return cfg;
+ free_irq_cfg(at, cfg);
+ }
+ }
+
+ res = irq_realloc_desc_at(at, node);
+ if (res >= 0) {
+ cfg = alloc_irq_cfg(at, node);
+ if (cfg) {
+ irq_set_chip_data(at, cfg);
+ return cfg;
+ }
+ }
+
+ return alloc_irq_and_cfg_at(at, node);
+}
+
struct io_apic {
unsigned int index;
unsigned int unused[3];
@@ -3563,7 +3594,7 @@ int arch_setup_ht_irq(unsigned int irq, struct pci_dev *dev)
static int
io_apic_setup_irq_pin(unsigned int irq, int node, struct io_apic_irq_attr *attr)
{
- struct irq_cfg *cfg = alloc_irq_and_cfg_at(irq, node);
+ struct irq_cfg *cfg = realloc_irq_and_cfg_at(irq, node);
int ret;
if (!cfg)
diff --git a/include/linux/irq.h b/include/linux/irq.h
index 7a9a19b..e15bc35 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -584,6 +584,11 @@ void irq_free_descs(unsigned int irq, unsigned int cnt);
int irq_reserve_irqs(unsigned int from, unsigned int cnt);
int __irq_reserve_irqs(int irq, unsigned int from, unsigned int cnt);
+int __irq_realloc_desc(int at, int node, struct module *owner);
+/* use macros to avoid needing export.h for THIS_MODULE */
+#define irq_realloc_desc_at(at, node) \
+ __irq_realloc_desc(at, node, THIS_MODULE)
+
static inline void irq_free_desc(unsigned int irq)
{
irq_free_descs(irq, 1);
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 3e23bb9..b1d6e51 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -99,6 +99,11 @@ EXPORT_SYMBOL_GPL(nr_irqs);
static DEFINE_MUTEX(sparse_irq_lock);
static DECLARE_BITMAP(allocated_irqs, IRQ_BITMAP_BITS);
+static bool __irq_is_reserved(int irq)
+{
+ return !!test_bit(irq, allocated_irqs);
+}
+
#ifdef CONFIG_SPARSE_IRQ
static RADIX_TREE(irq_desc_tree, GFP_KERNEL);
@@ -400,6 +405,27 @@ __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
EXPORT_SYMBOL_GPL(__irq_alloc_descs);
/**
+ * irq_realloc_desc - allocate irq descriptor for irq that is already reserved
+ * @irq: Allocate for specific irq number if irq >= 0
+ * @node: Preferred node on which the irq descriptor should be allocated
+ * @owner: Owning module (can be NULL)
+ *
+ * Returns the irq number or error code
+ */
+int __ref
+__irq_realloc_desc(int irq, int node, struct module *owner)
+{
+ if (!__irq_is_reserved(irq))
+ return -EINVAL;
+
+ if (irq_to_desc(irq))
+ free_desc(irq);
+
+ return alloc_descs(irq, 1, node, owner);
+}
+EXPORT_SYMBOL_GPL(__irq_realloc_desc);
+
+/**
* irq_reserve_irqs - mark irqs allocated
* @from: mark from irq number
* @cnt: number of irqs to mark
--
1.7.7
next prev parent reply other threads:[~2012-02-24 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 3:48 [PATCH 00/13] x86, irq: support ioapic device hotplug for x86 Yinghai Lu
2012-02-24 3:48 ` [PATCH 01/13] x86, irq: Convert irq_2_pin list to generic list Yinghai Lu
2012-02-24 3:48 ` [PATCH 02/13] genirq: Split __irq_reserve_irqs from irq_alloc_descs Yinghai Lu
2012-02-24 3:48 ` Yinghai Lu [this message]
2012-02-24 3:48 ` [PATCH 04/13] x86, irq: pre-reserve irq range that are used by ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 05/13] x86, irq: add ioapic_gsi_to_irq Yinghai Lu
2012-02-24 3:48 ` [PATCH 06/13] genirq: bail out early in free_desc() Yinghai Lu
2012-02-24 3:48 ` [PATCH 07/13] x86, irq: more strict check for register ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 08/13] x86, irq: Make mp_register_ioapic could handle hotadd ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 09/13] x86, irq: Add mp_unregister_ioapic could handle hotremove ioapic Yinghai Lu
2012-02-24 3:48 ` [PATCH 10/13] x86, irq: Make ioapics loop code skip blank slot Yinghai Lu
2012-02-24 3:48 ` [PATCH 11/13] x86, acpi, irq: Enable pci device type ioapic hotplug Yinghai Lu
2012-02-24 3:48 ` [PATCH 12/13] PCI: Make sure hotplug ioapic driver get loaded early Yinghai Lu
2012-02-24 3:48 ` [PATCH 13/13] PCI: Disable mem in the ioapic removing path Yinghai Lu
2012-02-24 16:51 ` [PATCH 00/13] x86, irq: support ioapic device hotplug for x86 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330055339-11662-4-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).