From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet15.oracle.com ([148.87.113.117]:39520 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932704Ab2CJHDa (ORCPT ); Sat, 10 Mar 2012 02:03:30 -0500 From: Yinghai Lu To: Jesse Barnes , x86 Cc: Bjorn Helgaas , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu Subject: [PATCH v2 37/37] PCI, sysfs: Prepare to kill pci device rescan Date: Fri, 9 Mar 2012 23:00:37 -0800 Message-Id: <1331362837-10740-38-git-send-email-yinghai@kernel.org> In-Reply-To: <1331362837-10740-1-git-send-email-yinghai@kernel.org> References: <1331362837-10740-1-git-send-email-yinghai@kernel.org> Sender: linux-pci-owner@vger.kernel.org List-ID: Hope we can kill it after one year. Print warning to catch real users for that feature. Signed-off-by: Yinghai Lu --- Documentation/feature-removal-schedule.txt | 9 +++++++++ drivers/pci/pci-sysfs.c | 3 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index a0ffac0..1b984a1 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -299,6 +299,15 @@ Why: In 2.6.27, the semantics of /sys/bus/pci/slots was redefined to fakephp interface. Who: Alex Chiang +----------------------------- + +What: /sys/bus/pci/devices/.../rescan +When: April 2013 +Why: That rescan will rescan pci parent's bus. It is confusing. + Now we have bridge rescan_bridge and bus rescan, and they could + be used on exact device and bus that need to be rescaned. +Who: Yinghai Lu + --------------------------- What: CONFIG_RFKILL_INPUT diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index fc0a7de..c180455 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -320,6 +320,9 @@ dev_rescan_store(struct device *dev, struct device_attribute *attr, return -EINVAL; if (val) { + printk(KERN_WARNING "rescan with pci device will be removed " + "shortly, please use bridge rescan_bridge\n" + "or bus/rescan instead\n"); mutex_lock(&pci_remove_rescan_mutex); pci_rescan_bus(pdev->bus); mutex_unlock(&pci_remove_rescan_mutex); -- 1.7.7