From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jiang Liu To: Yinghai Lu , Jesse Barnes , Bjorn Helgaas Cc: Jiang Liu , Ashok Raj , Suresh Siddha , Youquan Song , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, chenkeping@huawei.com Subject: [PATCH 1/5] Fix device reference count leakage in pci_dev_present() Date: Mon, 12 Mar 2012 01:48:25 +0800 Message-Id: <1331488109-13466-2-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1331488109-13466-1-git-send-email-jiang.liu@huawei.com> References: <1331488109-13466-1-git-send-email-jiang.liu@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: This patch fixes a pci device reference count leakage issue in function pci_dev_present(). Signed-off-by: Jiang Liu --- drivers/pci/search.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/search.c b/drivers/pci/search.c index 9d75dc8..b572730 100644 --- a/drivers/pci/search.c +++ b/drivers/pci/search.c @@ -338,13 +338,13 @@ int pci_dev_present(const struct pci_device_id *ids) WARN_ON(in_interrupt()); while (ids->vendor || ids->subvendor || ids->class_mask) { found = pci_get_dev_by_id(ids, NULL); - if (found) - goto exit; + if (found) { + pci_dev_put(found); + return 1; + } ids++; } -exit: - if (found) - return 1; + return 0; } EXPORT_SYMBOL(pci_dev_present); -- 1.7.5.4