From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, x86 <x86@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 11/12] PCI, cphi_hotplug: Simplify configure_slot
Date: Tue, 13 Mar 2012 00:26:33 -0700 [thread overview]
Message-ID: <1331623594-30543-12-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1331623594-30543-1-git-send-email-yinghai@kernel.org>
For child p2p bridge hotplug support should use pci_scan_bridge instead.
Make it more simillar to pciehp, just use pci_hp_add_bridge()
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/hotplug/cpci_hotplug_pci.c | 35 +++++--------------------------
1 files changed, 6 insertions(+), 29 deletions(-)
diff --git a/drivers/pci/hotplug/cpci_hotplug_pci.c b/drivers/pci/hotplug/cpci_hotplug_pci.c
index 4ef80ad..dcc75c7 100644
--- a/drivers/pci/hotplug/cpci_hotplug_pci.c
+++ b/drivers/pci/hotplug/cpci_hotplug_pci.c
@@ -285,42 +285,19 @@ int __ref cpci_configure_slot(struct slot *slot)
for (fn = 0; fn < 8; fn++) {
struct pci_dev *dev;
- dev = pci_get_slot(parent, PCI_DEVFN(PCI_SLOT(slot->devfn), fn));
+ dev = pci_get_slot(parent,
+ PCI_DEVFN(PCI_SLOT(slot->devfn), fn));
if (!dev)
continue;
if ((dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) ||
- (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)) {
- /* Find an unused bus number for the new bridge */
- struct pci_bus *child;
- unsigned char busnr, start = parent->secondary;
- unsigned char end = parent->subordinate;
-
- for (busnr = start; busnr <= end; busnr++) {
- if (!pci_find_bus(pci_domain_nr(parent),
- busnr))
- break;
- }
- if (busnr >= end) {
- err("No free bus for hot-added bridge\n");
- pci_dev_put(dev);
- continue;
- }
- child = pci_add_new_bus(parent, dev, busnr);
- if (!child) {
- err("Cannot add new bus for %s\n",
- pci_name(dev));
- pci_dev_put(dev);
- continue;
- }
- child->subordinate = pci_do_scan_bus(child);
- pci_bus_size_bridges_with_self(child);
- }
+ (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS))
+ pci_hp_add_bridge(dev);
pci_dev_put(dev);
}
- pci_bus_assign_resources(parent);
+ pci_assign_unassigned_bridge_resources(parent->self);
+
pci_bus_add_devices(parent);
- pci_enable_bridges(parent);
dbg("%s - exit", __func__);
return 0;
--
1.7.7
next prev parent reply other threads:[~2012-03-13 7:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 7:26 [PATCH 00/12] PCI, x86: More pci hotplug related cleanup Yinghai Lu
2012-03-13 7:26 ` [PATCH 01/12] PCI: Add debug print out for pci related dev release Yinghai Lu
2012-03-13 7:26 ` [PATCH 02/12] x86, PCI: Let pcibios_allocate_bus_resources() take bus instead Yinghai Lu
2012-03-13 7:26 ` [PATCH 03/12] PCI: Claim hw/fw allocated resources in hot add path Yinghai Lu
2012-03-13 7:26 ` [PATCH 04/12] PCI: Kill pci_is_reassignedev() Yinghai Lu
2012-03-13 7:26 ` [PATCH 05/12] PCI: Add addon_resource support for pci_dev Yinghai Lu
2012-03-15 21:30 ` Bjorn Helgaas
2012-03-16 3:23 ` Yinghai Lu
2012-03-13 7:26 ` [PATCH 06/12] PCI: Use for_each_pci_dev_resource helper Yinghai Lu
2012-03-13 7:26 ` [PATCH 07/12] PCI: Make piix4 quirk to use addon_resource support Yinghai Lu
2012-03-15 21:36 ` Bjorn Helgaas
2012-03-13 7:26 ` [PATCH 08/12] PCI: Make quirk_io_region " Yinghai Lu
2012-03-13 7:26 ` [PATCH 09/12] PCI: Use addon_fixed_resource with ati fixed resource Yinghai Lu
2012-03-13 7:26 ` [PATCH 10/12] PCI, pciehp: Separate pci_hp_add_bridge() Yinghai Lu
2012-03-15 21:42 ` Bjorn Helgaas
2012-03-13 7:26 ` Yinghai Lu [this message]
2012-03-13 7:26 ` [PATCH 12/12] PCI, shpchp: Simplify configure_device Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331623594-30543-12-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).