linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, x86 <x86@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH -v3 08/11] x86, PCI: Embed name into pci_root_info struct
Date: Sun, 18 Mar 2012 22:40:21 -0700	[thread overview]
Message-ID: <1332135624-13528-9-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1332135624-13528-1-git-send-email-yinghai@kernel.org>

Now we allocate info, and keep that in during whole life of host bridge.

So don't allocate info->name seperately, just put name into struct.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
 arch/x86/pci/acpi.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 2b74a16..23e7361 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x86/pci/acpi.c
@@ -9,7 +9,7 @@
 
 struct pci_root_info {
 	struct acpi_device *bridge;
-	char *name;
+	char name[16];
 	unsigned int res_num;
 	struct resource *res;
 	int busnum;
@@ -317,7 +317,6 @@ static void add_resources(struct pci_root_info *info,
 
 static void free_pci_root_info_res(struct pci_root_info *info)
 {
-	kfree(info->name);
 	kfree(info->res);
 	info->res = NULL;
 	info->res_num = 0;
@@ -370,9 +369,7 @@ probe_pci_root_info(struct pci_root_info *info, struct acpi_device *device,
 	if (!info->res)
 		return;
 
-	info->name = kasprintf(GFP_KERNEL, "PCI Bus %04x:%02x", domain, busnum);
-	if (!info->name)
-		return;
+	sprintf(info->name, "PCI Bus %04x:%02x", domain, busnum);
 
 	acpi_walk_resources(device->handle, METHOD_NAME__CRS, setup_resource,
 				info);
-- 
1.7.7


  parent reply	other threads:[~2012-03-19  5:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19  5:40 [PATCH -v3 00/11] PCI: pci_host_bridge related cleanup Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 01/11] PCI: Separate host_bridge code out from probe.c Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 02/11] x86, PCI: Fix memleak with get_current_resources() Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 03/11] PCI: Rename pci_host_bridge() to find_pci_root_bridge() Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 04/11] PCI: Add generic device into pci_host_bridge struct Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 05/11] PCI: Add host bridge release support Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 06/11] x86, PCI: Break down get_current_resource() Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 07/11] x86, PCI: Add host bridge resource release for _CRS path Yinghai Lu
2012-03-19  5:40 ` Yinghai Lu [this message]
2012-03-19  5:40 ` [PATCH -v3 09/11] x86, PCI: Embed pci_sysdata into pci_root_info on acpi path Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 10/11] x86, PCI: Allocate pci_root_info for not using _CRS path Yinghai Lu
2012-03-19  5:40 ` [PATCH -v3 11/11] x86, PCI: Merge root info printing " Yinghai Lu
2012-04-30 22:59 ` [PATCH -v3 00/11] PCI: pci_host_bridge related cleanup Bjorn Helgaas
2012-05-01  0:28   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332135624-13528-9-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).