From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from acsinet15.oracle.com ([141.146.126.227]:25512 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161952Ab2CSFtw (ORCPT ); Mon, 19 Mar 2012 01:49:52 -0400 From: Yinghai Lu To: Jesse Barnes , x86 Cc: Bjorn Helgaas , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu Subject: [PATCH -v2 15/26] PCI: Use for_each_res pci bases pci_dev_driver() Date: Sun, 18 Mar 2012 22:48:38 -0700 Message-Id: <1332136129-14010-16-git-send-email-yinghai@kernel.org> In-Reply-To: <1332136129-14010-1-git-send-email-yinghai@kernel.org> References: <1332136129-14010-1-git-send-email-yinghai@kernel.org> Sender: linux-pci-owner@vger.kernel.org List-ID: Replace those open code, and make code more readable. Signed-off-by: Yinghai Lu --- drivers/pci/pci-driver.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 5d19695..a82c66f 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1201,9 +1201,11 @@ pci_dev_driver(const struct pci_dev *dev) if (dev->driver) return dev->driver; else { + struct resource *res; int i; - for(i=0; i<=PCI_ROM_RESOURCE; i++) - if (dev->resource[i].flags & IORESOURCE_BUSY) + + for_each_pci_dev_base_resource((struct pci_dev *)dev, res, i) + if (res->flags & IORESOURCE_BUSY) return &pci_compat_driver; } return NULL; -- 1.7.7